[lldb] [llvm] Modify the localCache API to require an explicit commit on CachedFile… (PR #136121)

[Teresa Johnson via llvm-commits]

teresajohnson wrote:

> I'm away for the long weekend but can revert on Wednesday if nobody does so before then. However, I'm not sure how we can track down such lurking issues other than by leaving this unreverted and fixing issues as they pop up, since neither code review nor testcases caught #138194 . Do you have any recommendations other than just not making this API change and leaving the localCache API without proper error handling?

I've added some questions on that PR, after looking closely at the 2 changes I'm not really sure how this change produced or is related to the crash being fixed there.

https://github.com/llvm/llvm-project/pull/136121