[llvm] [SelectionDAG] Fix incorrect fold condition in foldSetCCWithFunnelShift. (PR #137637)

via llvm-commits llvm-commits at lists.llvm.org
Sat May 3 00:55:57 PDT 2025


================
@@ -4462,7 +4462,8 @@ static SDValue foldSetCCWithFunnelShift(EVT VT, SDValue N0, SDValue N1,
 
   unsigned BitWidth = N0.getScalarValueSizeInBits();
   auto *ShAmtC = isConstOrConstSplat(N0.getOperand(2));
-  if (!ShAmtC || ShAmtC->getAPIntValue().uge(BitWidth))
+  APInt AmtVal = ShAmtC->getAPIntValue();
+  if (!ShAmtC || AmtVal.uge(BitWidth) || AmtVal.isZero())
----------------
Ruhung wrote:

@jayfoad Sorry for the initial misunderstanding, it's OK to take the modulo first and then check whether it's zero ([Alive2](https://alive2.llvm.org/ce/z/TQYM-m)). I've fixed it. Thanks!

https://github.com/llvm/llvm-project/pull/137637


More information about the llvm-commits mailing list