[llvm] [VPlan] Manage noalias/alias_scope metadata in VPlan. (NFC) (PR #136450)

via llvm-commits llvm-commits at lists.llvm.org
Fri May 2 13:09:54 PDT 2025


================
@@ -2760,9 +2759,7 @@ void VPWidenLoadRecipe::execute(VPTransformState &State) {
   } else {
     NewLI = Builder.CreateAlignedLoad(DataTy, Addr, Alignment, "wide.load");
   }
-  // Add metadata to the load, but set the result to the reverse shuffle, if
-  // needed.
-  State.addNewMetadata(cast<Instruction>(NewLI), &Ingredient);
+  // Add metadata to the load, but setVectorValue to the reverse shuffle.
----------------
ayalz wrote:

Comment is apparently misleading ... IIUC it tries to explain why applyMetadata() operates on the original NewLI ("the load") while State.set() operates on the *possibly* reversed load - what may or may not be needed ("if needed") is the reverse shuffle?

https://github.com/llvm/llvm-project/pull/136450


More information about the llvm-commits mailing list