[llvm] [TableGen][NFC] Use early exit to simplify large block in emitAction. (PR #138220)
Jason Eckhardt via llvm-commits
llvm-commits at lists.llvm.org
Fri May 2 11:54:08 PDT 2025
https://github.com/nvjle updated https://github.com/llvm/llvm-project/pull/138220
>From f142ebcdaeb009c81307aa3b1b16f195c98570ec Mon Sep 17 00:00:00 2001
From: Jason Eckhardt <jeckhardt at nvidia.com>
Date: Thu, 1 May 2025 18:47:23 -0500
Subject: [PATCH] [TableGen][NFC] Use early exit to simplify large block in
emitAction.
Most of the processing in emitAction is in an unneeded else-block--
reduce indentation by exiting after the recursive call.
Also use ranged-for in one instance.
`XXXGenCallingConv.inc` are identical before and after this patch for
all targets.
---
llvm/utils/TableGen/CallingConvEmitter.cpp | 233 ++++++++++-----------
1 file changed, 115 insertions(+), 118 deletions(-)
diff --git a/llvm/utils/TableGen/CallingConvEmitter.cpp b/llvm/utils/TableGen/CallingConvEmitter.cpp
index 20dc1ff0ffd14..75d292076fd3c 100644
--- a/llvm/utils/TableGen/CallingConvEmitter.cpp
+++ b/llvm/utils/TableGen/CallingConvEmitter.cpp
@@ -204,13 +204,11 @@ void CallingConvEmitter::emitAction(const Record *Action, indent Indent,
if (Action->isSubClassOf("CCIfType")) {
const ListInit *VTs = Action->getValueAsListInit("VTs");
- for (unsigned I = 0, E = VTs->size(); I != E; ++I) {
- const Record *VT = VTs->getElementAsRecord(I);
- if (I != 0)
- O << " ||\n " << Indent;
- O << "LocVT == " << getEnumName(getValueType(VT));
+ ListSeparator LS(" ||\n " + std::string(Indent.NumIndents, ' '));
+ for (const Init *I : VTs->getValues()) {
+ const Record *VT = cast<DefInit>(I)->getDef();
+ O << LS << "LocVT == " << getEnumName(getValueType(VT));
}
-
} else if (Action->isSubClassOf("CCIf")) {
O << Action->getValueAsString("Predicate");
} else {
@@ -221,120 +219,119 @@ void CallingConvEmitter::emitAction(const Record *Action, indent Indent,
O << ") {\n";
emitAction(Action->getValueAsDef("SubAction"), Indent + 2, O);
O << Indent << "}\n";
- } else {
- if (Action->isSubClassOf("CCDelegateTo")) {
- const Record *CC = Action->getValueAsDef("CC");
- O << Indent << "if (!" << CC->getName()
- << "(ValNo, ValVT, LocVT, LocInfo, ArgFlags, State))\n"
- << Indent + 2 << "return false;\n";
- DelegateToMap[CurrentAction].insert(CC->getName().str());
- } else if (Action->isSubClassOf("CCAssignToReg") ||
- Action->isSubClassOf("CCAssignToRegTuple") ||
- Action->isSubClassOf("CCAssignToRegAndStack")) {
- const ListInit *RegList = Action->getValueAsListInit("RegList");
- for (unsigned I = 0, E = RegList->size(); I != E; ++I) {
- std::string Name = getQualifiedRegisterName(RegList->getElement(I));
- if (SwiftAction)
- AssignedSwiftRegsMap[CurrentAction].insert(std::move(Name));
- else
- AssignedRegsMap[CurrentAction].insert(std::move(Name));
- }
- EmitAllocateReg({RegList}, {"RegList"});
-
- if (Action->isSubClassOf("CCAssignToRegAndStack"))
- EmitAllocateStack();
-
- O << Indent << " return false;\n";
- O << Indent << "}\n";
- } else if (Action->isSubClassOf("CCAssignToRegWithShadow")) {
- const ListInit *RegList = Action->getValueAsListInit("RegList");
- const ListInit *ShadowRegList =
- Action->getValueAsListInit("ShadowRegList");
- if (!ShadowRegList->empty() && ShadowRegList->size() != RegList->size())
- PrintFatalError(Action->getLoc(),
- "Invalid length of list of shadowed registers");
-
- EmitAllocateReg({RegList, ShadowRegList}, {"RegList", "RegList"});
-
- O << Indent << " return false;\n";
- O << Indent << "}\n";
- } else if (Action->isSubClassOf("CCAssignToStack")) {
- EmitAllocateStack(/*EmitOffset=*/true);
- O << Indent << "State.addLoc(CCValAssign::getMem(ValNo, ValVT, Offset"
- << Counter << ", LocVT, LocInfo));\n";
- O << Indent << "return false;\n";
- } else if (Action->isSubClassOf("CCAssignToStackWithShadow")) {
- int Size = Action->getValueAsInt("Size");
- int Align = Action->getValueAsInt("Align");
- const ListInit *ShadowRegList =
- Action->getValueAsListInit("ShadowRegList");
-
- unsigned ShadowRegListNumber = ++Counter;
- EmitRegList(ShadowRegList, "ShadowRegList" + utostr(ShadowRegListNumber));
-
- O << Indent << "int64_t Offset" << ++Counter << " = State.AllocateStack("
- << Size << ", Align(" << Align << "), "
- << "ShadowRegList" << ShadowRegListNumber << ");\n";
- O << Indent << "State.addLoc(CCValAssign::getMem(ValNo, ValVT, Offset"
- << Counter << ", LocVT, LocInfo));\n";
- O << Indent << "return false;\n";
- } else if (Action->isSubClassOf("CCPromoteToType")) {
- const Record *DestTy = Action->getValueAsDef("DestTy");
- MVT::SimpleValueType DestVT = getValueType(DestTy);
- O << Indent << "LocVT = " << getEnumName(DestVT) << ";\n";
- if (MVT(DestVT).isFloatingPoint()) {
- O << Indent << "LocInfo = CCValAssign::FPExt;\n";
- } else {
- O << Indent << "if (ArgFlags.isSExt())\n"
- << Indent << " LocInfo = CCValAssign::SExt;\n"
- << Indent << "else if (ArgFlags.isZExt())\n"
- << Indent << " LocInfo = CCValAssign::ZExt;\n"
- << Indent << "else\n"
- << Indent << " LocInfo = CCValAssign::AExt;\n";
- }
- } else if (Action->isSubClassOf("CCPromoteToUpperBitsInType")) {
- const Record *DestTy = Action->getValueAsDef("DestTy");
- MVT::SimpleValueType DestVT = getValueType(DestTy);
- O << Indent << "LocVT = " << getEnumName(DestVT) << ";\n";
- if (MVT(DestVT).isFloatingPoint()) {
- PrintFatalError(Action->getLoc(),
- "CCPromoteToUpperBitsInType does not handle floating "
- "point");
- } else {
- O << Indent << "if (ArgFlags.isSExt())\n"
- << Indent << " LocInfo = CCValAssign::SExtUpper;\n"
- << Indent << "else if (ArgFlags.isZExt())\n"
- << Indent << " LocInfo = CCValAssign::ZExtUpper;\n"
- << Indent << "else\n"
- << Indent << " LocInfo = CCValAssign::AExtUpper;\n";
- }
- } else if (Action->isSubClassOf("CCBitConvertToType")) {
- const Record *DestTy = Action->getValueAsDef("DestTy");
- O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
- O << Indent << "LocInfo = CCValAssign::BCvt;\n";
- } else if (Action->isSubClassOf("CCTruncToType")) {
- const Record *DestTy = Action->getValueAsDef("DestTy");
- O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
- O << Indent << "LocInfo = CCValAssign::Trunc;\n";
- } else if (Action->isSubClassOf("CCPassIndirect")) {
- const Record *DestTy = Action->getValueAsDef("DestTy");
- O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
- O << Indent << "LocInfo = CCValAssign::Indirect;\n";
- } else if (Action->isSubClassOf("CCPassByVal")) {
- int Size = Action->getValueAsInt("Size");
- int Align = Action->getValueAsInt("Align");
- O << Indent << "State.HandleByVal(ValNo, ValVT, LocVT, LocInfo, " << Size
- << ", Align(" << Align << "), ArgFlags);\n";
- O << Indent << "return false;\n";
- } else if (Action->isSubClassOf("CCCustom")) {
- O << Indent << "if (" << Action->getValueAsString("FuncName")
- << "(ValNo, ValVT, "
- << "LocVT, LocInfo, ArgFlags, State))\n";
- O << Indent << " return false;\n";
+ return;
+ }
+
+ if (Action->isSubClassOf("CCDelegateTo")) {
+ const Record *CC = Action->getValueAsDef("CC");
+ O << Indent << "if (!" << CC->getName()
+ << "(ValNo, ValVT, LocVT, LocInfo, ArgFlags, State))\n"
+ << Indent + 2 << "return false;\n";
+ DelegateToMap[CurrentAction].insert(CC->getName().str());
+ } else if (Action->isSubClassOf("CCAssignToReg") ||
+ Action->isSubClassOf("CCAssignToRegTuple") ||
+ Action->isSubClassOf("CCAssignToRegAndStack")) {
+ const ListInit *RegList = Action->getValueAsListInit("RegList");
+ for (unsigned I = 0, E = RegList->size(); I != E; ++I) {
+ std::string Name = getQualifiedRegisterName(RegList->getElement(I));
+ if (SwiftAction)
+ AssignedSwiftRegsMap[CurrentAction].insert(std::move(Name));
+ else
+ AssignedRegsMap[CurrentAction].insert(std::move(Name));
+ }
+ EmitAllocateReg({RegList}, {"RegList"});
+
+ if (Action->isSubClassOf("CCAssignToRegAndStack"))
+ EmitAllocateStack();
+
+ O << Indent << " return false;\n";
+ O << Indent << "}\n";
+ } else if (Action->isSubClassOf("CCAssignToRegWithShadow")) {
+ const ListInit *RegList = Action->getValueAsListInit("RegList");
+ const ListInit *ShadowRegList = Action->getValueAsListInit("ShadowRegList");
+ if (!ShadowRegList->empty() && ShadowRegList->size() != RegList->size())
+ PrintFatalError(Action->getLoc(),
+ "Invalid length of list of shadowed registers");
+
+ EmitAllocateReg({RegList, ShadowRegList}, {"RegList", "RegList"});
+
+ O << Indent << " return false;\n";
+ O << Indent << "}\n";
+ } else if (Action->isSubClassOf("CCAssignToStack")) {
+ EmitAllocateStack(/*EmitOffset=*/true);
+ O << Indent << "State.addLoc(CCValAssign::getMem(ValNo, ValVT, Offset"
+ << Counter << ", LocVT, LocInfo));\n";
+ O << Indent << "return false;\n";
+ } else if (Action->isSubClassOf("CCAssignToStackWithShadow")) {
+ int Size = Action->getValueAsInt("Size");
+ int Align = Action->getValueAsInt("Align");
+ const ListInit *ShadowRegList = Action->getValueAsListInit("ShadowRegList");
+
+ unsigned ShadowRegListNumber = ++Counter;
+ EmitRegList(ShadowRegList, "ShadowRegList" + utostr(ShadowRegListNumber));
+
+ O << Indent << "int64_t Offset" << ++Counter << " = State.AllocateStack("
+ << Size << ", Align(" << Align << "), "
+ << "ShadowRegList" << ShadowRegListNumber << ");\n";
+ O << Indent << "State.addLoc(CCValAssign::getMem(ValNo, ValVT, Offset"
+ << Counter << ", LocVT, LocInfo));\n";
+ O << Indent << "return false;\n";
+ } else if (Action->isSubClassOf("CCPromoteToType")) {
+ const Record *DestTy = Action->getValueAsDef("DestTy");
+ MVT::SimpleValueType DestVT = getValueType(DestTy);
+ O << Indent << "LocVT = " << getEnumName(DestVT) << ";\n";
+ if (MVT(DestVT).isFloatingPoint()) {
+ O << Indent << "LocInfo = CCValAssign::FPExt;\n";
} else {
- errs() << *Action;
- PrintFatalError(Action->getLoc(), "Unknown CCAction!");
+ O << Indent << "if (ArgFlags.isSExt())\n"
+ << Indent << " LocInfo = CCValAssign::SExt;\n"
+ << Indent << "else if (ArgFlags.isZExt())\n"
+ << Indent << " LocInfo = CCValAssign::ZExt;\n"
+ << Indent << "else\n"
+ << Indent << " LocInfo = CCValAssign::AExt;\n";
+ }
+ } else if (Action->isSubClassOf("CCPromoteToUpperBitsInType")) {
+ const Record *DestTy = Action->getValueAsDef("DestTy");
+ MVT::SimpleValueType DestVT = getValueType(DestTy);
+ O << Indent << "LocVT = " << getEnumName(DestVT) << ";\n";
+ if (MVT(DestVT).isFloatingPoint()) {
+ PrintFatalError(Action->getLoc(),
+ "CCPromoteToUpperBitsInType does not handle floating "
+ "point");
+ } else {
+ O << Indent << "if (ArgFlags.isSExt())\n"
+ << Indent << " LocInfo = CCValAssign::SExtUpper;\n"
+ << Indent << "else if (ArgFlags.isZExt())\n"
+ << Indent << " LocInfo = CCValAssign::ZExtUpper;\n"
+ << Indent << "else\n"
+ << Indent << " LocInfo = CCValAssign::AExtUpper;\n";
}
+ } else if (Action->isSubClassOf("CCBitConvertToType")) {
+ const Record *DestTy = Action->getValueAsDef("DestTy");
+ O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
+ O << Indent << "LocInfo = CCValAssign::BCvt;\n";
+ } else if (Action->isSubClassOf("CCTruncToType")) {
+ const Record *DestTy = Action->getValueAsDef("DestTy");
+ O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
+ O << Indent << "LocInfo = CCValAssign::Trunc;\n";
+ } else if (Action->isSubClassOf("CCPassIndirect")) {
+ const Record *DestTy = Action->getValueAsDef("DestTy");
+ O << Indent << "LocVT = " << getEnumName(getValueType(DestTy)) << ";\n";
+ O << Indent << "LocInfo = CCValAssign::Indirect;\n";
+ } else if (Action->isSubClassOf("CCPassByVal")) {
+ int Size = Action->getValueAsInt("Size");
+ int Align = Action->getValueAsInt("Align");
+ O << Indent << "State.HandleByVal(ValNo, ValVT, LocVT, LocInfo, " << Size
+ << ", Align(" << Align << "), ArgFlags);\n";
+ O << Indent << "return false;\n";
+ } else if (Action->isSubClassOf("CCCustom")) {
+ O << Indent << "if (" << Action->getValueAsString("FuncName")
+ << "(ValNo, ValVT, "
+ << "LocVT, LocInfo, ArgFlags, State))\n";
+ O << Indent << " return false;\n";
+ } else {
+ errs() << *Action;
+ PrintFatalError(Action->getLoc(), "Unknown CCAction!");
}
}
More information about the llvm-commits
mailing list