[llvm] [SelectionDAG] Fix incorrect fold condition in foldSetCCWithFunnelShift. (PR #137637)

Jay Foad via llvm-commits llvm-commits at lists.llvm.org
Fri May 2 07:20:13 PDT 2025


================
@@ -4462,7 +4462,8 @@ static SDValue foldSetCCWithFunnelShift(EVT VT, SDValue N0, SDValue N1,
 
   unsigned BitWidth = N0.getScalarValueSizeInBits();
   auto *ShAmtC = isConstOrConstSplat(N0.getOperand(2));
-  if (!ShAmtC || ShAmtC->getAPIntValue().uge(BitWidth))
+  APInt AmtVal = ShAmtC->getAPIntValue();
+  if (!ShAmtC || AmtVal.uge(BitWidth) || AmtVal.isZero())
----------------
jayfoad wrote:

> It looks like it might only be fshr that is incorrect

What is "incorrect" here? (I was not pointing out a bug, just a way to make the implementation a bit simpler _and_ handle more cases.)

https://github.com/llvm/llvm-project/pull/137637


More information about the llvm-commits mailing list