[llvm] [DirectX] Adding support for Root Descriptors in obj2yaml/yaml2obj (PR #137259)
Damyan Pepper via llvm-commits
llvm-commits at lists.llvm.org
Thu May 1 18:04:39 PDT 2025
================
@@ -121,16 +121,19 @@ namespace DirectX {
struct RootParameterView {
const dxbc::RootParameterHeader &Header;
StringRef ParamData;
- RootParameterView(const dxbc::RootParameterHeader &H, StringRef P)
+ RootParameterView(uint32_t V, const dxbc::RootParameterHeader &H, StringRef P)
----------------
damyanp wrote:
It looks like other constructors have `V` stand for "View".
But regardless, it is literally unused:
```c++
RootParameterView(uint32_t V, const dxbc::RootParameterHeader &H, StringRef P)
: Header(H), ParamData(P) {}
```
RootDescriptorView does have a Version passed to it's read method. But this V passed to the RootParameterView constructor is not used.
https://github.com/llvm/llvm-project/pull/137259
More information about the llvm-commits
mailing list