[llvm] c2bec64 - [AMDGPU] Simplify GCNTTIImpl::isValidAddrSpaceCast. NFCI. (#137986)

via llvm-commits llvm-commits at lists.llvm.org
Thu May 1 12:18:52 PDT 2025


Author: Jay Foad
Date: 2025-05-01T20:18:48+01:00
New Revision: c2bec64833753df539ab9089555e8c039c33b9bb

URL: https://github.com/llvm/llvm-project/commit/c2bec64833753df539ab9089555e8c039c33b9bb
DIFF: https://github.com/llvm/llvm-project/commit/c2bec64833753df539ab9089555e8c039c33b9bb.diff

LOG: [AMDGPU] Simplify GCNTTIImpl::isValidAddrSpaceCast. NFCI. (#137986)

This just removes some code that references specific address spaces.

Added: 
    

Modified: 
    llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
index 7ad60829f9a01..1ee4d73a47866 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
+++ b/llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.h
@@ -182,20 +182,8 @@ class GCNTTIImpl final : public BasicTTIImplBase<GCNTTIImpl> {
     if (FromAS == ToAS)
       return false;
 
-    if (FromAS == AMDGPUAS::FLAT_ADDRESS)
-      return AMDGPU::isExtendedGlobalAddrSpace(ToAS) ||
-             ToAS == AMDGPUAS::LOCAL_ADDRESS ||
-             ToAS == AMDGPUAS::PRIVATE_ADDRESS;
-
-    if (AMDGPU::isExtendedGlobalAddrSpace(FromAS))
-      return AMDGPU::isFlatGlobalAddrSpace(ToAS) ||
-             ToAS == AMDGPUAS::CONSTANT_ADDRESS_32BIT;
-
-    if (FromAS == AMDGPUAS::LOCAL_ADDRESS ||
-        FromAS == AMDGPUAS::PRIVATE_ADDRESS)
-      return ToAS == AMDGPUAS::FLAT_ADDRESS;
-
-    return false;
+    // Casts between any aliasing address spaces are valid.
+    return AMDGPU::addrspacesMayAlias(FromAS, ToAS);
   }
 
   bool addrspacesMayAlias(unsigned AS0, unsigned AS1) const override {


        


More information about the llvm-commits mailing list