[llvm] Reland [llvm] Add support for llvm IR atomicrmw fminimum/fmaximum instructions (PR #137701)

Kazu Hirata via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 30 20:54:27 PDT 2025


kazutakahirata wrote:

This patch seems to break the flang build (`bin/flang`).

```
tools/mlir/include/mlir/Dialect/LLVMIR/LLVMConversionEnumsFromLLVM.inc:11:11: error: enumeration values 'FMaximum' and 'FMinimum' not handled in switch [-Werror,-Wswitch]
  switch (value) {
          ^~~~~
1 error generated.
```

If I revert 60c9f3fd89ab60ddda7bd6d27a65948ff8188d23, 4ac4ad410ca5ed8b83ff397246aa6ac27742690d, and 6e49f73825f1b9cb98352a7c8dca3e0cf83ebd9e (this PR), then the flang build is restored.

Is there any way you could take a look?  Thanks in advance!

I'm not sure why other builders haven't picked up the build failure.  I've removed my build directory, re-ran cmake, and tried to build `bin/flang`.  Even then the build failure persists.


https://github.com/llvm/llvm-project/pull/137701


More information about the llvm-commits mailing list