[llvm] [DeadStoreElimination] Visit blocks in RPO traversal when initializing DSEState (PR #137815)
Nikita Popov via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 29 07:17:27 PDT 2025
https://github.com/nikic commented:
Isn't this also going to invert the order for other places iterating MemDeps?
Generally it makes sense to me to have consistent block and instruction iteration order (i.e. either use PO + reverse(BB) or RPO + BB), but I don't think this change is right by itself.
It's also not really clear to me what the actual issue you are trying to fix is. You are testing debug output, but does this also make a difference on optimization behavior?
https://github.com/llvm/llvm-project/pull/137815
More information about the llvm-commits
mailing list