[llvm] [x86] Enable indirect tail calls with more arguments (PR #137643)
Hans Wennborg via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 29 05:38:14 PDT 2025
zmodem wrote:
I also don't feel super confident with the DAG stuff. One positive is that we're good at asserting when there's an issue with the graph structure. That makes me more comfortable touching this code.
The current version builds Chromium for Linux (x64) and Windows (x86 and x64) asserts free (I found and fixed one issue).
The `load ; store ; call load` case is covered by https://github.com/llvm/llvm-project/blob/2f976956e5ccef566418853015fb6b31257aa69f/llvm/test/CodeGen/X86/fold-call.ll#L20-L26 Having inline asm in between also seems bad (a pre-existing bug?), so I added a check for that too.
The `hasOneUse()` checks I added generally prevent loops, which trigger asserts in the lit tests.
https://github.com/llvm/llvm-project/pull/137643
More information about the llvm-commits
mailing list