[llvm] [DSE] Simpily if condition (NFC) (PR #137777)

via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 29 02:51:24 PDT 2025


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-llvm-transforms

Author: None (NewSigma)

<details>
<summary>Changes</summary>

Note that the key-value pair has already been initialized, so assignment is not necessary.

---
Full diff: https://github.com/llvm/llvm-project/pull/137777.diff


1 Files Affected:

- (modified) llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp (+2-4) 


``````````diff
diff --git a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
index 0521df8b818cf..ce210fc26a871 100644
--- a/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
+++ b/llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp
@@ -1210,13 +1210,11 @@ struct DSEState {
   bool isInvisibleToCallerAfterRet(const Value *V) {
     if (isa<AllocaInst>(V))
       return true;
+
     auto I = InvisibleToCallerAfterRet.insert({V, false});
     if (I.second) {
-      if (!isInvisibleToCallerOnUnwind(V)) {
-        I.first->second = false;
-      } else if (isNoAliasCall(V)) {
+      if (isInvisibleToCallerOnUnwind(V) && isNoAliasCall(V))
         I.first->second = !PointerMayBeCaptured(V, /*ReturnCaptures=*/true);
-      }
     }
     return I.first->second;
   }

``````````

</details>


https://github.com/llvm/llvm-project/pull/137777


More information about the llvm-commits mailing list