[llvm] [llvm] annotate interfaces in llvm/Support for DLL export (PR #136014)

[Nikita Popov via llvm-commits]

================
@@ -67,7 +68,7 @@ class BPFunctionNode {
   /// The ID of this node
   IDT Id;
 
-  void dump(raw_ostream &OS) const;
+  LLVM_ABI void dump(raw_ostream &OS) const;
----------------
nikic wrote:

I don't really agree with the omission of dump() from the ABI. If dump methods are enabled, they should be exported, we don't want them to get internalized and optimized away.

If we do want to exclude them, isn't it necessary to annotate them with LLVM_ABI_NOT_EXPORTED so that ids doesn't re-add the annotation on the next run?

https://github.com/llvm/llvm-project/pull/136014