[llvm] [DAG] Add utilities for inserting and extracting low sub-vectors [nfc] (PR #137230)

Philip Reames via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 28 12:59:53 PDT 2025


================
@@ -924,6 +924,18 @@ class SelectionDAG {
   /// Example: shuffle A, B, <0,5,2,7> -> shuffle B, A, <4,1,6,3>
   SDValue getCommutedVectorShuffle(const ShuffleVectorSDNode &SV);
 
+  /// Insert SubVec into the lowest sub-vector of Vec.
----------------
preames wrote:

I would find these names extremely confusing, as widen and narrow would be things I'd expect to be done element wise to the elements given those names.   I'm fine exploring the case with a undef passthru (that is fairly common), but these names really don't work.  

https://github.com/llvm/llvm-project/pull/137230


More information about the llvm-commits mailing list