[lld] [lld-macho]Added missing commit from PR/135241 (PR #137672)

Vy Nguyen via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 28 10:23:52 PDT 2025


https://github.com/oontvoo created https://github.com/llvm/llvm-project/pull/137672

None

>From 3c0949181950629f0e5dab1febe072a70221efd0 Mon Sep 17 00:00:00 2001
From: Vy Nguyen <vyng at google.com>
Date: Mon, 28 Apr 2025 13:23:21 -0400
Subject: [PATCH] [lld-macho]Added missing commit from PR/135241

---
 lld/test/MachO/reexport-with-rpath.s | 20 +++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/lld/test/MachO/reexport-with-rpath.s b/lld/test/MachO/reexport-with-rpath.s
index 431962a9c2d8a..2672449d3cdbd 100644
--- a/lld/test/MachO/reexport-with-rpath.s
+++ b/lld/test/MachO/reexport-with-rpath.s
@@ -1,4 +1,12 @@
 # REQUIRES: x86
+## This tests that lld handles (re)exported libraries with rpath properly .
+## The tests are as follows:
+## - libAee re-exports libBee while defining the install-path with @rpath variable
+##   - libBee re-exports libCee while defining the install-path with @rpath variable
+##     - libCee contains _c_func symbol.
+##
+## We check that when linking a main which references _c_func, lld can find the symbol.
+
 # RUN: rm -rf %t; split-file %s %t
 # RUN: mkdir -p %t/cc/two/three
 # RUN: mkdir -p %t/bb/two/three
@@ -7,10 +15,12 @@
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/c.s -o %t/c.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/b.s -o %t/b.o
 # RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/a.s -o %t/a.o
+# RUN: llvm-mc -filetype=obj -triple=x86_64-apple-darwin %t/main.s -o %t/main.o
 
 # RUN: %lld -dylib -install_name @rpath/two/three/libCee.dylib %t/c.o -o %t/cc/two/three/libCee.dylib 
 # RUN: %lld -dylib -install_name @rpath/two/three/libBee.dylib -L%t/cc/two/three -sub_library libCee -lCee %t/b.o -o %t/bb/two/three/libBee.dylib -rpath %t/cc
-# RUN: %lld -dylib -install_name @rpath/two/three/libAee.dylib -L%t/bb/two/three -sub_library libBee -lBee %t/a.o -o %t/aa/two/three/libAee.dylib
+# RUN: %lld -dylib -install_name @rpath/two/three/libAee.dylib -L%t/bb/two/three -sub_library libBee -lBee %t/a.o -o %t/aa/two/three/libAee.dylib -rpath %t/aa
+# RUN: %lld %t/main.o  -L%t/aa/two/three -lAee -o a.out -rpath %t/aa -rpath %t/bb -rpath %t/cc
 
 #--- c.s
 .text
@@ -33,3 +43,11 @@ _b_func:
 _a_func:
   mov $0, %rax
   ret
+
+#--- main.s
+.globl _main
+_main:
+  callq _c_func
+  callq _b_func
+  callq _a_func
+  ret



More information about the llvm-commits mailing list