[llvm] [llvm] Add support for llvm IR atomicrmw fminimum/fmaximum instructions (PR #136759)

Mon Apr 28 07:52:21 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `fuchsia-x86_64-linux` running on `fuchsia-debian-64-us-central1-a-1` while building `llvm` at step 4 "annotate".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/11/builds/13960

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 4 (annotate) failure: 'python ../llvm-zorg/zorg/buildbot/builders/annotated/fuchsia-linux.py ...' (failure)
...
  Passed           : 45892 (97.97%)
  Expectedly Failed:    27 (0.06%)
[1382/1384] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
[1383/1384] Running the LLVM regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/wasm-ld
-- Testing: 58944 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60..
FAIL: LLVM :: TableGen/GlobalISelCombinerEmitter/match-table-cxx.td (40622 of 58944)
******************** TEST 'LLVM :: TableGen/GlobalISelCombinerEmitter/match-table-cxx.td' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/llvm-tblgen -I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/../../../include -gen-global-isel-combiner      -combiners=MyCombiner /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td |  /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td # RUN: at line 1
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/llvm-tblgen -I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/../../../include -gen-global-isel-combiner -combiners=MyCombiner /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td:99:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(205), /*)*//*default:*//*Label 5*/ GIMT_Encode4(500),
               ^
<stdin>:350:44: note: scanning from here
 constexpr static uint8_t MatchTable0[] = {
                                           ^
<stdin>:351:2: note: possible intended match here
 /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(207), /*)*//*default:*//*Label 5*/ GIMT_Encode4(508),
 ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           .
           .
           .
         345: #define GIMT_Encode2(Val) uint8_t((uint16_t)Val >> 8), uint8_t(Val) 
         346: #define GIMT_Encode4(Val) uint8_t((uint32_t)Val >> 24), uint8_t((uint32_t)Val >> 16), uint8_t((uint32_t)Val >> 8), uint8_t(Val) 
         347: #define GIMT_Encode8(Val) uint8_t((uint64_t)Val >> 56), uint8_t((uint64_t)Val >> 48), uint8_t((uint64_t)Val >> 40), uint8_t((uint64_t)Val >> 32), uint8_t((uint64_t)Val >> 24), uint8_t((uint64_t)Val >> 16), uint8_t((uint64_t)Val >> 8), uint8_t(Val) 
         348: #endif 
         349: const uint8_t *GenMyCombiner::getMatchTable() const { 
         350:  constexpr static uint8_t MatchTable0[] = { 
next:99'0                                                X error: no match found
         351:  /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(207), /*)*//*default:*//*Label 5*/ GIMT_Encode4(508), 
next:99'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:99'1      ?                                                                                                                             possible intended match
Step 7 (check) failure: check (failure)
...
  Passed           : 45892 (97.97%)
  Expectedly Failed:    27 (0.06%)
[1382/1384] Linking CXX executable unittests/Transforms/Scalar/ScalarTests
[1383/1384] Running the LLVM regression tests
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/ld.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using lld-link: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/lld-link
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using ld64.lld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/ld64.lld
llvm-lit: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/utils/lit/lit/llvm/config.py:520: note: using wasm-ld: /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/wasm-ld
-- Testing: 58944 tests, 60 workers --
Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60..
FAIL: LLVM :: TableGen/GlobalISelCombinerEmitter/match-table-cxx.td (40622 of 58944)
******************** TEST 'LLVM :: TableGen/GlobalISelCombinerEmitter/match-table-cxx.td' FAILED ********************
Exit Code: 1

Command Output (stderr):
--
/var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/llvm-tblgen -I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/../../../include -gen-global-isel-combiner      -combiners=MyCombiner /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td |  /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td # RUN: at line 1
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/FileCheck /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td
+ /var/lib/buildbot/fuchsia-x86_64-linux/build/llvm-build-qlu520wb/bin/llvm-tblgen -I /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/../../../include -gen-global-isel-combiner -combiners=MyCombiner /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td
/var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td:99:16: error: CHECK-NEXT: expected string not found in input
// CHECK-NEXT: /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(205), /*)*//*default:*//*Label 5*/ GIMT_Encode4(500),
               ^
<stdin>:350:44: note: scanning from here
 constexpr static uint8_t MatchTable0[] = {
                                           ^
<stdin>:351:2: note: possible intended match here
 /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(207), /*)*//*default:*//*Label 5*/ GIMT_Encode4(508),
 ^

Input file: <stdin>
Check file: /var/lib/buildbot/fuchsia-x86_64-linux/llvm-project/llvm/test/TableGen/GlobalISelCombinerEmitter/match-table-cxx.td

-dump-input=help explains the following input dump.

Input was:
<<<<<<
           .
           .
           .
         345: #define GIMT_Encode2(Val) uint8_t((uint16_t)Val >> 8), uint8_t(Val) 
         346: #define GIMT_Encode4(Val) uint8_t((uint32_t)Val >> 24), uint8_t((uint32_t)Val >> 16), uint8_t((uint32_t)Val >> 8), uint8_t(Val) 
         347: #define GIMT_Encode8(Val) uint8_t((uint64_t)Val >> 56), uint8_t((uint64_t)Val >> 48), uint8_t((uint64_t)Val >> 40), uint8_t((uint64_t)Val >> 32), uint8_t((uint64_t)Val >> 24), uint8_t((uint64_t)Val >> 16), uint8_t((uint64_t)Val >> 8), uint8_t(Val) 
         348: #endif 
         349: const uint8_t *GenMyCombiner::getMatchTable() const { 
         350:  constexpr static uint8_t MatchTable0[] = { 
next:99'0                                                X error: no match found
         351:  /* 0 */ GIM_SwitchOpcode, /*MI*/0, /*[*/GIMT_Encode2(99), GIMT_Encode2(207), /*)*//*default:*//*Label 5*/ GIMT_Encode4(508), 
next:99'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
next:99'1      ?                                                                                                                             possible intended match

```

</details>

https://github.com/llvm/llvm-project/pull/136759