[llvm] [AArch64] Don't allow mixed partial reductions without i8mm (PR #137602)

David Sherwood via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 28 05:31:29 PDT 2025


================
@@ -5345,10 +5345,9 @@ InstructionCost AArch64TTIImpl::getPartialReductionCost(
     return Invalid;
 
   // AArch64 supports lowering mixed extensions to a usdot but only if the
-  // i8mm or sve/streaming features are available.
+  // i8mm feature is available.
   if (OpAExtend == TTI::PR_None || OpBExtend == TTI::PR_None ||
-      (OpAExtend != OpBExtend && !ST->hasMatMulInt8() &&
-       !ST->isSVEorStreamingSVEAvailable()))
+      (OpAExtend != OpBExtend && !ST->hasMatMulInt8()))
----------------
david-arm wrote:

I guess this should be:

```
    (OpAExtend != OpBExtend && (!ST->hasMatMulInt8() || !ST->isSVEorStreamingSVEAvailable())))
```

?

https://github.com/llvm/llvm-project/pull/137602


More information about the llvm-commits mailing list