[llvm] [VPlan] Manage noalias/alias_scope metadata in VPlan. (NFC) (PR #136450)

[Florian Hahn via llvm-commits]

================
@@ -2760,9 +2759,7 @@ void VPWidenLoadRecipe::execute(VPTransformState &State) {
   } else {
     NewLI = Builder.CreateAlignedLoad(DataTy, Addr, Alignment, "wide.load");
   }
-  // Add metadata to the load, but set the result to the reverse shuffle, if
-  // needed.
-  State.addNewMetadata(cast<Instruction>(NewLI), &Ingredient);
+  // Add metadata to the load, but setVectorValue to the reverse shuffle.
----------------
fhahn wrote:

Could retain it, but it seems a bit confusing as we are not checking here if it is needed; `applyMetadata` implicitly only adds the metadata 'when needed', if no metadata is needed, the recipe won't have metadata.

https://github.com/llvm/llvm-project/pull/136450