[llvm] [Analysis] Ensure use of strict fp exceptions in ConstantFolding (PR #136139)

Mon Apr 28 02:17:09 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-sles-build-only` running on `rocm-worker-hw-04-sles` while building `llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/140/builds/22085

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
5.026 [4792/32/2337] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BlockFrequencyInfo.cpp.o
5.027 [4791/32/2338] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BlockFrequencyInfoImpl.cpp.o
5.031 [4790/32/2339] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFG.cpp.o
5.031 [4789/32/2340] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/BranchProbabilityInfo.cpp.o
5.032 [4788/32/2341] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFGPrinter.cpp.o
5.032 [4787/32/2342] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CFGSCCPrinter.cpp.o
5.036 [4786/32/2343] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CGSCCPassManager.cpp.o
5.038 [4785/32/2344] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CallGraph.cpp.o
5.039 [4784/32/2345] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CallGraphSCCPass.cpp.o
5.040 [4783/32/2346] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstantFolding.cpp.o
FAILED: lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstantFolding.cpp.o 
ccache /usr/bin/c++ -DGTEST_HAS_RTTI=0 -DHAS_LOGF128 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -Ilib/Analysis -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis -Iinclude -I/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wno-comment -Wno-misleading-indentation -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++1z -ffp-exception-behavior=strict -MD -MT lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstantFolding.cpp.o -MF lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstantFolding.cpp.o.d -o lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstantFolding.cpp.o -c /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/ConstantFolding.cpp
c++: error: unrecognized command line option ‘-ffp-exception-behavior=strict’
5.040 [4783/31/2347] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CallPrinter.cpp.o
5.041 [4783/30/2348] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CaptureTracking.cpp.o
5.044 [4783/29/2349] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CmpInstAnalysis.cpp.o
5.049 [4783/28/2350] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CostModel.cpp.o
5.050 [4783/27/2351] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CodeMetrics.cpp.o
5.051 [4783/26/2352] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CycleAnalysis.cpp.o
5.052 [4783/25/2353] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/ConstraintSystem.cpp.o
5.053 [4783/24/2354] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DDGPrinter.cpp.o
5.054 [4783/23/2355] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/DDG.cpp.o
5.055 [4783/22/2356] Building CXX object lib/Analysis/CMakeFiles/LLVMAnalysis.dir/CtxProfAnalysis.cpp.o
In file included from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include/llvm/Analysis/CtxProfAnalysis.h:17:0,
                 from /home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:14:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include/llvm/ProfileData/PGOCtxProfReader.h: In member function ‘void llvm::PGOCtxProfContext::ingestAllContexts(uint32_t, llvm::PGOCtxProfContext::CallTargetMapTy&&)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/include/llvm/ProfileData/PGOCtxProfReader.h:152:22: warning: unused variable ‘_’ [-Wunused-variable]
     auto [_, Inserted] = callsites().try_emplace(CSId, std::move(Other));
                      ^
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp: In constructor ‘llvm::ProfileAnnotatorImpl::ProfileAnnotatorImpl(const llvm::Function&, llvm::ArrayRef<long unsigned int>)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:332:20: warning: unused variable ‘It’ [-Wunused-variable]
       auto [It, Ins] =
                    ^
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp: In member function ‘llvm::PGOContextualProfile llvm::CtxProfAnalysis::run(llvm::Module&, llvm::ModuleAnalysisManager&)’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:505:28: warning: unused variable ‘_’ [-Wunused-variable]
     for (auto &[RootGuid, _] :
                            ^
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp: In member function ‘const CtxProfFlatProfile llvm::PGOContextualProfile::flatten() const’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:703:31: warning: unused variable ‘_’ [-Wunused-variable]
   for (const auto &[_, CtxRoot] : Profiles.Contexts) {
                               ^
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp: In member function ‘const CtxProfFlatIndirectCallProfile llvm::PGOContextualProfile::flattenVirtCalls() const’:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:722:31: warning: unused variable ‘_’ [-Wunused-variable]
   for (const auto &[_, CtxRoot] : Profiles.Contexts) {
                               ^
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp: In lambda function:
/home/botworker/bbot/builds/openmp-offload-sles-build/llvm.src/llvm/lib/Analysis/CtxProfAnalysis.cpp:749:34: warning: unused variable ‘_’ [-Wunused-variable]
         for (const auto &[Guid, _] : Targets->second)
                                  ^

```

</details>

https://github.com/llvm/llvm-project/pull/136139