[llvm] IR: Avoid repeating assert condition in Value destructor (PR #136340)

Sat Apr 19 12:55:07 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls-2stage` running on `linaro-g3-04` while building `llvm` at step 12 "ninja check 2".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/4/builds/6321

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 12 (ninja check 2) failure: stage 2 checked (failure)
...
[173/173] Linking CXX executable flang-rt/unittests/Runtime/RuntimeTests
[684/1396] Linking CXX executable tools/clang/unittests/ASTMatchers/ASTMatchersTests
clang++: warning: argument unused during compilation: '-mllvm -treat-scalable-fixed-error-as-warning=false' [-Wunused-command-line-argument]
[710/1396] Linking CXX executable tools/clang/unittests/AST/ASTTests
clang++: warning: argument unused during compilation: '-mllvm -treat-scalable-fixed-error-as-warning=false' [-Wunused-command-line-argument]
[712/1396] Linking CXX executable tools/clang/unittests/Format/FormatTests
clang++: warning: argument unused during compilation: '-mllvm -treat-scalable-fixed-error-as-warning=false' [-Wunused-command-line-argument]
[775/1396] Linking CXX executable unittests/ADT/ADTTests
clang++: warning: argument unused during compilation: '-mllvm -treat-scalable-fixed-error-as-warning=false' [-Wunused-command-line-argument]
[786/1396] Linking CXX executable unittests/BinaryFormat/BinaryFormatTests
FAILED: unittests/BinaryFormat/BinaryFormatTests 
: && /home/tcwg-buildbot/worker/clang-aarch64-sve-vls-2stage/stage1.install/bin/clang++ -mcpu=neoverse-512tvb -msve-vector-bits=256 -mllvm -treat-scalable-fixed-error-as-warning=false -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Werror=unguarded-availability-new -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wmissing-field-initializers -pedantic -Wno-long-long -Wc++98-compat-extra-semi -Wimplicit-fallthrough -Wcovered-switch-default -Wno-noexcept-type -Wnon-virtual-dtor -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wstring-conversion -Wmisleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -fuse-ld=lld -Wl,--color-diagnostics    -Wl,--gc-sections unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/DwarfTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/ELFTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/MachOTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/MsgPackDocumentTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/MsgPackReaderTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/MsgPackWriterTest.cpp.o unittests/BinaryFormat/CMakeFiles/BinaryFormatTests.dir/TestFileMagic.cpp.o -o unittests/BinaryFormat/BinaryFormatTests  lib/libLLVMBinaryFormat.a  lib/libLLVMTargetParser.a  lib/libLLVMSupport.a  lib/libllvm_gtest_main.a  lib/libllvm_gtest.a  lib/libLLVMSupport.a  -lrt  -ldl  -lm  /usr/lib/aarch64-linux-gnu/libz.so  lib/libLLVMDemangle.a  -lpthread && :
clang++: error: no such file or directory: 'lib/libllvm_gtest_main.a'
[787/1396] Building CXX object unittests/CGData/CMakeFiles/CGDataTests.dir/StableFunctionMapTest.cpp.o
[789/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineAdvisorAnalysisTest.cpp.o
[790/1396] Building CXX object unittests/Bitstream/CMakeFiles/BitstreamTests.dir/BitstreamWriterTest.cpp.o
[791/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/PluginInlineOrderAnalysisTest.cpp.o
[792/1396] Building CXX object unittests/Bitcode/CMakeFiles/BitcodeTests.dir/BitReaderTest.cpp.o
[793/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/DIEHashTest.cpp.o
[794/1396] Building CXX object unittests/AsmParser/CMakeFiles/AsmParserTests.dir/AsmParserTest.cpp.o
[795/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/IRSimilarityIdentifierTest.cpp.o
[796/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/MachineInstrBundleIteratorTest.cpp.o
[797/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/CtxProfAnalysisTest.cpp.o
[798/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/ScalableVectorMVTsTest.cpp.o
[799/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/DwarfStringPoolEntryRefTest.cpp.o
[800/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/FunctionPropertiesAnalysisTest.cpp.o
[801/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TargetOptionsTest.cpp.o
[802/1396] Building CXX object unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/GUIDFormatTest.cpp.o
[803/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/LowLevelTypeTest.cpp.o
[804/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/LazyCallGraphTest.cpp.o
[805/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/VectorUtilsTest.cpp.o
[806/1396] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/CallLowering.cpp.o
[807/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/ReplaceWithVecLibTest.cpp.o
[808/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/ScalarEvolutionTest.cpp.o
[809/1396] Building CXX object unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/TypeHashingTest.cpp.o
[810/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/CGSCCPassManagerTest.cpp.o
[811/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/CCStateTest.cpp.o
[812/1396] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GIMatchTableExecutorTest.cpp.o
[813/1396] Building CXX object tools/flang/unittests/Frontend/CMakeFiles/FlangFrontendTests.dir/CompilerInstanceTest.cpp.o
[814/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/DroppedVariableStatsMIRTest.cpp.o
[815/1396] Building CXX object unittests/Analysis/CMakeFiles/AnalysisTests.dir/ValueTrackingTest.cpp.o
[816/1396] Building CXX object unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/RandomAccessVisitorTest.cpp.o
[817/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/AArch64SelectionDAGTest.cpp.o
[818/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/TypeTraitsTest.cpp.o
[819/1396] Building CXX object unittests/DebugInfo/CodeView/CMakeFiles/DebugInfoCodeViewTests.dir/TypeIndexDiscoveryTest.cpp.o
[820/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SchedBoundary.cpp.o
[821/1396] Building CXX object tools/flang/unittests/Frontend/CMakeFiles/FlangFrontendTests.dir/CodeGenActionTest.cpp.o
[822/1396] Building CXX object unittests/CodeGen/CMakeFiles/CodeGenTests.dir/SelectionDAGAddressAnalysisTest.cpp.o
[823/1396] Building CXX object unittests/CodeGen/GlobalISel/CMakeFiles/GlobalISelTests.dir/GISelMITest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/136340