[clang] [llvm] [DirectX] add Function name to DiagnosticInfoUnsupported Msg in DXILOpLowering (PR #136234)

Justin Bogner via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 18 14:35:45 PDT 2025


================
@@ -139,7 +139,7 @@ class DiagnosticInfo {
 using DiagnosticHandlerFunction = std::function<void(const DiagnosticInfo &)>;
 
 class DiagnosticInfoGeneric : public DiagnosticInfo {
-  const Twine &MsgStr;
+  const Twine MsgStr;
----------------
bogner wrote:

All of the Twine usage in Diagnostic info is super sketchy. I think we can drop this from this change and do it more comprehensively here: https://github.com/llvm/llvm-project/pull/136371

https://github.com/llvm/llvm-project/pull/136234


More information about the llvm-commits mailing list