[llvm] [HLSL] XFAIL `smoothstep.ll` and `SV_GroupIndex.ll` SPIR-V backend tests (PR #136343)
via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 18 11:46:19 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-backend-spir-v
Author: Kaitlin Peng (kmpeng)
<details>
<summary>Changes</summary>
Temporarily fixes #<!-- -->136049.
SPIRV-Tools seems to have [grown some capability checks for vulkan 1.3](https://github.com/KhronosGroup/SPIRV-Tools/commit/7e41c7130f8258bf2d62179d8d6dbf3b68a7978b), which broke:
- `CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll`
- `CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll`
For now the fix is to XFAIL these tests to unblock the pipeline.
---
Full diff: https://github.com/llvm/llvm-project/pull/136343.diff
2 Files Affected:
- (modified) llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll (+3)
- (modified) llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll (+3)
``````````diff
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
index 83caa62150cda..f5be558929b52 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/SV_GroupIndex.ll
@@ -1,6 +1,9 @@
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-vulkan-unknown %s -o - | FileCheck %s
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-vulkan-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
; CHECK-DAG: %[[#int:]] = OpTypeInt 32 0
; CHECK-DAG: %[[#ptr_Input_int:]] = OpTypePointer Input %[[#int]]
; CHECK-DAG: %[[#LocalInvocationIndex:]] = OpVariable %[[#ptr_Input_int]] Input
diff --git a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
index e0e04dd0faf58..64f3287f43416 100644
--- a/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
+++ b/llvm/test/CodeGen/SPIRV/hlsl-intrinsics/smoothstep.ll
@@ -1,6 +1,9 @@
; RUN: llc -O0 -verify-machineinstrs -mtriple=spirv-unknown-unknown %s -o - | FileCheck %s
; RUN: %if spirv-tools %{ llc -O0 -mtriple=spirv-unknown-unknown %s -o - -filetype=obj | spirv-val --target-env vulkan1.3 %}
+; TODO: This test currently fails when --target-env vulkan1.3 is specified.
+; XFAIL: *
+
; Make sure SPIRV operation function calls for smoothstep are lowered correctly.
; CHECK-DAG: %[[#op_ext_glsl:]] = OpExtInstImport "GLSL.std.450"
``````````
</details>
https://github.com/llvm/llvm-project/pull/136343
More information about the llvm-commits
mailing list