[llvm] f696508 - [BFI] Revert use of append_range (NFC)

Nikita Popov via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 18 10:00:15 PDT 2025


Author: Nikita Popov
Date: 2025-04-18T19:00:07+02:00
New Revision: f696508b38d1958aac5992a98a90fe6e773e8709

URL: https://github.com/llvm/llvm-project/commit/f696508b38d1958aac5992a98a90fe6e773e8709
DIFF: https://github.com/llvm/llvm-project/commit/f696508b38d1958aac5992a98a90fe6e773e8709.diff

LOG: [BFI] Revert use of append_range (NFC)

This is a partial revert of #136066, which introduced a compile-time
regression. SmallVector::insert() computes the PostOrderIterator
twice in order to call reserve().

Added: 
    

Modified: 
    llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h b/llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h
index 2237f105e328b..66ea5ecbc4bfb 100644
--- a/llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h
+++ b/llvm/include/llvm/Analysis/BlockFrequencyInfoImpl.h
@@ -1160,7 +1160,7 @@ void BlockFrequencyInfoImpl<BT>::setBlockFreq(const BlockT *BB,
 template <class BT> void BlockFrequencyInfoImpl<BT>::initializeRPOT() {
   const BlockT *Entry = &F->front();
   RPOT.reserve(F->size());
-  llvm::append_range(RPOT, post_order(Entry));
+  std::copy(po_begin(Entry), po_end(Entry), std::back_inserter(RPOT));
   std::reverse(RPOT.begin(), RPOT.end());
 
   assert(RPOT.size() - 1 <= BlockNode::getMaxIndex() &&


        


More information about the llvm-commits mailing list