[clang] [llvm] [HLSL][RootSignature] Implement initial parsing of the descriptor table clause params (PR #133800)

Thu Apr 17 20:58:34 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime-2` running on `rocm-worker-hw-02` while building `clang,llvm` at step 5 "compile-openmp".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/10/builds/3703

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (compile-openmp) failure: build (failure)
...
3.026 [3109/64/1444] Building CXX object lib/CodeGen/CMakeFiles/LLVMCodeGen.dir/MachinePipeliner.cpp.o
3.027 [3108/64/1445] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AbstractCallSite.cpp.o
3.028 [3107/64/1446] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Assumptions.cpp.o
3.030 [3106/64/1447] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AsmWriter.cpp.o
3.034 [3105/64/1448] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Attributes.cpp.o
3.036 [3104/64/1449] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/BuiltinGCs.cpp.o
3.037 [3103/64/1450] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/BasicBlock.cpp.o
3.038 [3102/64/1451] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/AutoUpgrade.cpp.o
3.039 [3101/64/1452] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Comdat.cpp.o
3.041 [3100/64/1453] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o
FAILED: tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/tools/clang/lib/Parse -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/tools/clang/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.build/include -I/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -MF tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o.d -o tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSLRootSignature.cpp.o -c /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseHLSLRootSignature.cpp
In file included from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/include/clang/Parse/ParseHLSLRootSignature.h:23,
                 from /home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/clang/lib/Parse/ParseHLSLRootSignature.cpp:9:
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:42:12: error: declaration of ‘llvm::hlsl::rootsig::Register llvm::hlsl::rootsig::DescriptorTableClause::Register’ changes meaning of ‘Register’ [-fpermissive]
   42 |   Register Register;
      |            ^~~~~~~~
/home/botworker/builds/openmp-offload-amdgpu-runtime-2/llvm.src/llvm/include/llvm/Frontend/HLSL/HLSLRootSignature.h:28:8: note: ‘Register’ declared here as ‘struct llvm::hlsl::rootsig::Register’
   28 | struct Register {
      |        ^~~~~~~~
3.044 [3100/63/1454] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ConstantFold.cpp.o
3.045 [3100/62/1455] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ConstantFPRange.cpp.o
3.047 [3100/61/1456] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ConstantRange.cpp.o
3.048 [3100/60/1457] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/ConstantRangeList.cpp.o
3.050 [3100/59/1458] Building CXX object lib/IR/CMakeFiles/LLVMCore.dir/Constants.cpp.o
3.052 [3100/58/1459] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/Warnings.cpp.o
3.161 [3100/57/1460] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/BackendUtil.cpp.o
3.163 [3100/56/1461] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/MacroPPCallbacks.cpp.o
3.217 [3100/55/1462] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/LinkInModulesPass.cpp.o
3.348 [3100/54/1463] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CoverageMappingGen.cpp.o
3.409 [3100/53/1464] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenAction.cpp.o
3.444 [3100/52/1465] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/ObjectFilePCHContainerWriter.cpp.o
3.473 [3100/51/1466] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenPGO.cpp.o
3.522 [3100/50/1467] Building CXX object tools/clang/lib/CodeGen/CMakeFiles/obj.clangCodeGen.dir/CodeGenModule.cpp.o
3.628 [3100/49/1468] Building X86GenFastISel.inc...
3.840 [3100/48/1469] Building X86GenGlobalISel.inc...
4.219 [3100/47/1470] Building X86GenSubtargetInfo.inc...
4.756 [3100/46/1471] Building X86GenDAGISel.inc...
5.596 [3100/45/1472] Building X86GenInstrInfo.inc...
7.131 [3100/44/1473] Building CXX object tools/clang/lib/Basic/CMakeFiles/obj.clangBasic.dir/DiagnosticIDs.cpp.o
7.193 [3100/43/1474] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseAST.cpp.o
7.564 [3100/42/1475] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseHLSL.cpp.o
7.624 [3100/41/1476] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseInit.cpp.o
7.974 [3100/40/1477] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTentative.cpp.o
8.242 [3100/39/1478] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseCXXInlineMethods.cpp.o
8.261 [3100/38/1479] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseTemplate.cpp.o
8.430 [3100/37/1480] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseOpenACC.cpp.o
8.494 [3100/36/1481] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/Parser.cpp.o
8.822 [3100/35/1482] Building CXX object tools/clang/lib/Parse/CMakeFiles/obj.clangParse.dir/ParseExprCXX.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/133800