[llvm] [NVPTX] Basic support for fp128 as a storage type (PR #136006)
Artem Belevich via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 17 14:32:23 PDT 2025
================
@@ -111,27 +111,22 @@ class LLVM_LIBRARY_VISIBILITY NVPTXAsmPrinter : public AsmPrinter {
// Copy Num bytes from Ptr.
// if Bytes > Num, zero fill up to Bytes.
- unsigned addBytes(unsigned char *Ptr, int Num, int Bytes) {
- assert((curpos + Num) <= size);
- assert((curpos + Bytes) <= size);
- for (int i = 0; i < Num; ++i) {
- buffer[curpos] = Ptr[i];
- curpos++;
- }
- for (int i = Num; i < Bytes; ++i) {
- buffer[curpos] = 0;
- curpos++;
- }
- return curpos;
+ void addBytes(const unsigned char *Ptr, unsigned Num, unsigned Bytes) {
+ for (unsigned I : llvm::seq(Num))
+ addByte(Ptr[I]);
+ if (Bytes > Num)
+ addZeros(Bytes - Num);
}
- unsigned addZeros(int Num) {
- assert((curpos + Num) <= size);
- for (int i = 0; i < Num; ++i) {
- buffer[curpos] = 0;
- curpos++;
- }
- return curpos;
+ void addByte(uint8_t Byte) {
+ assert(curpos < size);
+ buffer[curpos] = Byte;
+ curpos++;
+ }
+
+ void addZeros(unsigned Num) {
+ for (unsigned _ : llvm::seq(Num))
----------------
Artem-B wrote:
Looks like we need `[[maybe_unused]]` here to avoid the warning.
https://github.com/llvm/llvm-project/pull/136006
More information about the llvm-commits
mailing list