[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

Wed Apr 16 11:14:50 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-with-lto-ubuntu` running on `as-worker-91` while building `clang,llvm` at step 6 "build-stage1-compiler".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/49/builds/1310

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 6 (build-stage1-compiler) failure: build (failure)
...
941.283 [172/72/6307] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MD5Test.cpp.o
941.386 [171/72/6308] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/InstructionCostTest.cpp.o
941.545 [170/72/6309] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MemoryBufferRefTest.cpp.o
941.711 [169/72/6310] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ModRefTest.cpp.o
941.898 [168/72/6311] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/BalancedPartitioningTest.cpp.o
942.106 [167/72/6312] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FileOutputBufferTest.cpp.o
942.430 [166/72/6313] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/LineIteratorTest.cpp.o
942.486 [165/72/6314] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/OptimizedStructLayoutTest.cpp.o
942.770 [164/72/6315] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RecyclerTest.cpp.o
942.860 [163/72/6316] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o
FAILED: unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/unittests/Support -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/unittests/Support -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/build/stage1/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/third-party/unittest/googletest/include -I/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG  -Wno-dangling-else -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -Wno-suggest-override -std=c++17 -MD -MT unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o -MF unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o.d -o unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o -c /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/unittests/Support/ProgramStackTest.cpp
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/unittests/Support/ProgramStackTest.cpp: In member function ‘virtual void ProgramStackTest_runOnNewStack_Test::TestBody()’:
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/unittests/Support/ProgramStackTest.cpp:33:16: error: call of overloaded ‘runOnNewStack(int, llvm::function_ref<void(int&)>, int&)’ is ambiguous
   33 |   runOnNewStack(0, function_ref<void(int &)>(func2), A);
      |   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/unittests/Support/ProgramStackTest.cpp:9:
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/include/llvm/Support/ProgramStack.h:48:3: note: candidate: ‘R llvm::runOnNewStack(unsigned int, llvm::function_ref<Ret(Params ...)>, Ts&& ...) [with R = void; Ts = {int&}]’
   48 | R runOnNewStack(unsigned StackSize, function_ref<R(Ts...)> Fn, Ts &&...Args) {
      |   ^~~~~~~~~~~~~
/home/buildbot/as-worker-91/clang-with-lto-ubuntu/llvm-project/llvm/include/llvm/Support/ProgramStack.h:55:6: note: candidate: ‘void llvm::runOnNewStack(unsigned int, llvm::function_ref<void(Ts ...)>, Ts&& ...) [with Ts = {int&}]’
   55 | void runOnNewStack(unsigned StackSize, function_ref<void(Ts...)> Fn,
      |      ^~~~~~~~~~~~~
943.043 [163/71/6317] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MatchersTest.cpp.o
943.072 [163/70/6318] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/PerThreadBumpPtrAllocatorTest.cpp.o
943.187 [163/69/6319] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/PassTest.cpp.o
943.211 [163/68/6320] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/NativeFormatTests.cpp.o
943.214 [163/67/6321] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/LockFileManagerTest.cpp.o
943.333 [163/66/6322] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o
943.371 [163/65/6323] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ProcessTest.cpp.o
943.476 [163/64/6324] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SHA256.cpp.o
943.510 [163/63/6325] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RISCVAttributeParserTest.cpp.o
943.629 [163/62/6326] Building CXX object unittests/ProfileData/CMakeFiles/ProfileDataTests.dir/SampleProfTest.cpp.o
943.847 [163/61/6327] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/GlobPatternTest.cpp.o
944.022 [163/60/6328] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ReplaceFileTest.cpp.o
944.127 [163/59/6329] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/RegionTest.cpp.o
944.143 [163/58/6330] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SipHashTest.cpp.o
944.269 [163/57/6331] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/DataExtractorTest.cpp.o
944.306 [163/56/6332] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/TimerTest.cpp.o
944.386 [163/55/6333] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FileCollectorTest.cpp.o
944.660 [163/54/6334] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RegexTest.cpp.o
944.881 [163/53/6335] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/TypeTraitsTest.cpp.o
944.965 [163/52/6336] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SignalsTest.cpp.o
944.999 [163/51/6337] Building CXX object unittests/Passes/Plugins/CMakeFiles/PluginsTests.dir/PluginsTest.cpp.o
945.027 [163/50/6338] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/UtilsTest.cpp.o
945.136 [163/49/6339] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/TypeNameTest.cpp.o
945.149 [163/48/6340] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SuffixTreeTest.cpp.o
945.205 [163/47/6341] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ParallelTest.cpp.o
945.209 [163/46/6342] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/TimeProfilerTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/133173