[llvm] [CodeGen] Construct SmallVector with ArrayRef (NFC) (PR #135930)
via llvm-commits
llvm-commits at lists.llvm.org
Wed Apr 16 00:56:45 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-selectiondag
Author: Kazu Hirata (kazutakahirata)
<details>
<summary>Changes</summary>
Note that we can drop the call to reserve because the constructor that
takes ArrayRef calls append, which in turn calls reserve.
---
Full diff: https://github.com/llvm/llvm-project/pull/135930.diff
1 Files Affected:
- (modified) llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp (+1-3)
``````````diff
diff --git a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
index d72be359867ca..8322d243b5bc3 100644
--- a/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ b/llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -24741,10 +24741,8 @@ static SDValue combineConcatVectorOfShuffleAndItsOperands(
// We are going to pad the shuffle operands, so any indice, that was picking
// from the second operand, must be adjusted.
- SmallVector<int, 16> AdjustedMask;
- AdjustedMask.reserve(SVN->getMask().size());
+ SmallVector<int, 16> AdjustedMask(SVN->getMask());
assert(SVN->getOperand(1).isUndef() && "Expected unary shuffle!");
- append_range(AdjustedMask, SVN->getMask());
// Identity masks for the operands of the (padded) shuffle.
SmallVector<int, 32> IdentityMask(2 * OpVT.getVectorNumElements());
``````````
</details>
https://github.com/llvm/llvm-project/pull/135930
More information about the llvm-commits
mailing list