[compiler-rt] [ASan] Mark recent integration tests as accordingly for MSVC (PR #135889)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 15 17:34:20 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: MacGyver Codilla (39otsu)
<details>
<summary>Changes</summary>
Both of these tests will cause an unsuccessful pass when using msvc.
`shadowed-stack-serialization.cpp` - XFAIL due to the metadata not being generated.
`fakeframe-right-redzone.cpp` - UNSUPPORTED due to the optimization limitations of the msvc compiler.
---
Full diff: https://github.com/llvm/llvm-project/pull/135889.diff
2 Files Affected:
- (modified) compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp (+1)
- (modified) compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp (+2)
``````````diff
diff --git a/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp b/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
index da1f5f2fb9789..6dd4bdaa02773 100644
--- a/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
+++ b/compiler-rt/test/asan/TestCases/fakeframe-right-redzone.cpp
@@ -1,5 +1,6 @@
// RUN: %clangxx_asan -O0 %s -o %t && %env_asan_opts=detect_stack_use_after_return=1 not %run %t 2>&1 | FileCheck %s
// RUN: %clangxx_asan -O0 %s -o %t -fsanitize-address-use-after-return=always && not %run %t 2>&1 | FileCheck %s
+// UNSUPPORTED: MSVC
#include "defines.h"
#include <stdint.h>
diff --git a/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp b/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
index 4018c097aed5a..6a88c3c9ea9be 100644
--- a/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
+++ b/compiler-rt/test/asan/TestCases/shadowed-stack-serialization.cpp
@@ -1,5 +1,7 @@
// RUN: %clangxx_asan -O0 %s -o %t
// RUN: not %run %t 2>&1 | FileCheck %s
+// MSVC marks this as xfail because it doesn't generate the metadata to display the variable's location in source.
+// XFAIL: msvc
int main() {
int x;
``````````
</details>
https://github.com/llvm/llvm-project/pull/135889
More information about the llvm-commits
mailing list