[clang] [llvm] [llvm][clang] Allocate a new stack instead of spawning a new thread to get more stack space (PR #133173)

Tue Apr 15 12:42:40 PDT 2025

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `clang-m68k-linux-cross` running on `suse-gary-m68k-cross` while building `clang,llvm` at step 5 "ninja check 1".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/27/builds/8674

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 5 (ninja check 1) failure: stage 1 checked (failure)
...
[888/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MemoryBufferRefTest.cpp.o
[889/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FileCollectorTest.cpp.o
[890/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/LockFileManagerTest.cpp.o
[891/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ModRefTest.cpp.o
[892/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/GlobPatternTest.cpp.o
[893/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ConvertUTFTest.cpp.o
[894/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/OptimizedStructLayoutTest.cpp.o
[895/1167] Building CXX object unittests/SandboxIR/CMakeFiles/SandboxIRTests.dir/TrackerTest.cpp.o
[896/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/NativeFormatTests.cpp.o
[897/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o
FAILED: unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o 
/usr/bin/c++ -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/unittests/Support -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/unittests/Support -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/stage1/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/third-party/unittest/googletest/include -I/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/third-party/unittest/googlemock/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-maybe-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -O3 -DNDEBUG -std=c++17  -Wno-dangling-else -Wno-variadic-macros -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -Wno-suggest-override -MD -MT unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o -MF unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o.d -o unittests/Support/CMakeFiles/SupportTests.dir/ProgramStackTest.cpp.o -c /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/unittests/Support/ProgramStackTest.cpp
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/unittests/Support/ProgramStackTest.cpp: In member function ‘virtual void ProgramStackTest_runOnNewStack_Test::TestBody()’:
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/unittests/Support/ProgramStackTest.cpp:33:16: error: call of overloaded ‘runOnNewStack(int, llvm::function_ref<void(int&)>, int&)’ is ambiguous
   33 |   runOnNewStack(0, function_ref<void(int &)>(func2), A);
      |   ~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
In file included from /var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/unittests/Support/ProgramStackTest.cpp:9:
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/include/llvm/Support/ProgramStack.h:48:3: note: candidate: ‘R llvm::runOnNewStack(unsigned int, function_ref<Ret(Params ...)>, Ts&& ...) [with R = void; Ts = {int&}]’
   48 | R runOnNewStack(unsigned StackSize, function_ref<R(Ts...)> Fn, Ts &&...Args) {
      |   ^~~~~~~~~~~~~
/var/lib/buildbot/workers/suse-gary-m68k-cross/clang-m68k-linux-cross/llvm/llvm/include/llvm/Support/ProgramStack.h:55:6: note: candidate: ‘void llvm::runOnNewStack(unsigned int, function_ref<void(Ts ...)>, Ts&& ...) [with Ts = {int&}]’
   55 | void runOnNewStack(unsigned StackSize, function_ref<void(Ts...)> Fn,
      |      ^~~~~~~~~~~~~
[898/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/PerThreadBumpPtrAllocatorTest.cpp.o
[899/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RecyclerTest.cpp.o
[900/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ProcessTest.cpp.o
[901/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/KnownBitsTest.cpp.o
[902/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RISCVAttributeParserTest.cpp.o
[903/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ReverseIterationTest.cpp.o
[904/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ReplaceFileTest.cpp.o
[905/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SHA256.cpp.o
[906/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/LEB128Test.cpp.o
[907/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SignalsTest.cpp.o
[908/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SipHashTest.cpp.o
[909/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MemoryTest.cpp.o
[910/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ParallelTest.cpp.o
[911/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/RegexTest.cpp.o
[912/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MemoryBufferTest.cpp.o
[913/1167] Building CXX object unittests/ProfileData/CMakeFiles/ProfileDataTests.dir/MemProfTest.cpp.o
[914/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ProgramTest.cpp.o
[915/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/ScopedPrinterTest.cpp.o
[916/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/JSONTest.cpp.o
[917/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/HashBuilderTest.cpp.o
[918/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/FormatVariadicTest.cpp.o
[919/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SpecialCaseListTest.cpp.o
[920/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/SourceMgrTest.cpp.o
[921/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MustacheTest.cpp.o
[922/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/MathExtrasTest.cpp.o
[923/1167] Building CXX object unittests/Support/CMakeFiles/SupportTests.dir/CommandLineTest.cpp.o

```

</details>

https://github.com/llvm/llvm-project/pull/133173