[llvm] [DAGCombiner] Fold and/or of NaN SETCC (PR #135645)

Alex MacLean via llvm-commits llvm-commits at lists.llvm.org
Tue Apr 15 11:11:12 PDT 2025


================
@@ -0,0 +1,45 @@
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 5
+; RUN: llc < %s -mtriple=nvptx64 | FileCheck %s
----------------
AlexMaclean wrote:

I think the current method of testing makes more sense. The output at that point will still contain target-specific opcodes and be subject to target-specific legalization, so writing FileCheck patterns that are generic enough to cover all targets will be quite difficult. Even if I can manage it, they won't be as clear and easy to automatically update as they are now. Relying on debug printing also seems somewhat brittle.

 It seems like fairly standard practice to test generic DAGCombiner changes with checks on a specific target. Of the last functional 10 changes in DAGCombiner I checked, all added or modified target specific tests while none modified CodeGen/Generic.

https://github.com/llvm/llvm-project/pull/135645


More information about the llvm-commits mailing list