[flang] [llvm] [mlir] [flang][llvm][OpenMP][OpenACC] Add implicit casts to omp.atomic and acc.atomic (PR #131603)
Kiran Chandramohan via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 15 08:44:10 PDT 2025
================
@@ -386,6 +442,7 @@ void genOmpAccAtomicRead(Fortran::lower::AbstractConverter &converter,
fir::getBase(converter.genExprAddr(fromExpr, stmtCtx));
mlir::Value toAddress = fir::getBase(converter.genExprAddr(
*Fortran::semantics::GetExpr(assignmentStmtVariable), stmtCtx));
+ emitImplicitCast(converter, loc, fromAddress, toAddress, elementType);
----------------
kiranchandramohan wrote:
1. Can you file a github issue for the capture case that is not supported?
2. Can you run the gfortran testsuite and Fujitsu testsuite and check that there are no regressions?
```
git clone https://github.com/llvm/llvm-test-suite.git
cd llvm-test-suite
mkdir build
cd build
cmake -DCMAKE_BUILD_TYPE=Release -DCMAKE_C_COMPILER=$HOME/llvm-project/build_release/bin/clang -DCMAKE_CXX_COMPILER=$HOME/llvm-project/build_release/bin/clang++ -DCMAKE_Fortran_COMPILER=$HOME/llvm-project/build_release/bin/flang-new -DTEST_SUITE_FORTRAN=On -DTEST_SUITE_SUBDIRS=Fortran -DTEST_SUITE_FORTRAN_ISO_C_HEADER_DIR=$HOME/llvm-project/flang/include/flang ../
make -j48
NO_STOP_MESSAGE=1 $HOME/llvm-project/build_release/bin/llvm-lit -v .
```
For Fujitsu, some tests will fail. So you have to record the number of passes and failures with and without your patch.
```
https://github.com/fujitsu/compiler-test-suite
```
https://github.com/llvm/llvm-project/pull/131603
More information about the llvm-commits
mailing list