[clang] [llvm] [HIP][HIPSTDPAR][NFC] Re-order & adapt `hipstdpar` specific passes (PR #134753)

[Alex Voicu via llvm-commits]

AlexVlx wrote:

> LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all".
> 
> Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/22732
> 
> Here is the relevant piece of the build log for the reference
> ```
> Step 6 (test-build-unified-tree-check-all) failure: test (failure)
> ******************** TEST 'Clang :: CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp' FAILED ********************
> Exit Code: 1
> 
> Command Output (stderr):
> --
> /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/21/include -nostdsysteminc -triple amdgcn-amd-amdhsa -mllvm -amdgpu-enable-hipstdpar -flto -emit-llvm-bc -fcuda-is-device -fdebug-pass-manager   /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp -o /dev/null 2>&1 | /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck --check-prefix=HIPSTDPAR-PRE /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp # RUN: at line 4
> + /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/21/include -nostdsysteminc -triple amdgcn-amd-amdhsa -mllvm -amdgpu-enable-hipstdpar -flto -emit-llvm-bc -fcuda-is-device -fdebug-pass-manager /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp -o /dev/null
> + /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/FileCheck --check-prefix=HIPSTDPAR-PRE /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp
> �[1m/home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp:6:19: �[0m�[0;1;31merror: �[0m�[1mHIPSTDPAR-PRE: expected string not found in input
> �[0m// HIPSTDPAR-PRE: Running pass: EntryExitInstrumenterPass
> �[0;1;32m                  ^
> �[0m�[1m<stdin>:1:1: �[0m�[0;1;30mnote: �[0m�[1mscanning from here
> �[0mclang (LLVM option parsing): Unknown command line argument '-amdgpu-enable-hipstdpar'. Try: 'clang (LLVM option parsing) --help'
> �[0;1;32m^
> �[0m�[1m<stdin>:1:26: �[0m�[0;1;30mnote: �[0m�[1mpossible intended match here
> �[0mclang (LLVM option parsing): Unknown command line argument '-amdgpu-enable-hipstdpar'. Try: 'clang (LLVM option parsing) --help'
> �[0;1;32m                         ^
> �[0m
> Input file: <stdin>
> Check file: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/CodeGenHipStdPar/select-accelerator-code-pass-ordering.cpp
> 
> -dump-input=help explains the following input dump.
> 
> Input was:
> <<<<<<
> �[1m�[0m�[0;1;30m           1: �[0m�[1m�[0;1;46mclang (LLVM option parsing): Unknown command line argument '-amdgpu-enable-hipstdpar'. Try: 'clang (LLVM option parsing) --help' �[0m
> �[0;1;31mcheck:6'0     X~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ error: no match found
> �[0m�[0;1;35mcheck:6'1                              ?                                                                                                        possible intended match
> �[0m�[0;1;30m           2: �[0m�[1m�[0;1;46mclang (LLVM option parsing): Did you mean '--enable-ipra'? �[0m
> �[0;1;31mcheck:6'0     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> �[0m>>>>>>
> 
> --
> 
> ********************
> ```

This looks somewhat odd and I'm not privy to the workings of the SIE bots (others seem to pass). Should this test require AMDGPU (guessing that the `fast` bot doesn't enable it)?

https://github.com/llvm/llvm-project/pull/134753