[llvm] [HLSL] Analyze updateCounter usage (PR #135669)
Ashley Coleman via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 14 13:26:14 PDT 2025
================
@@ -463,7 +463,7 @@ class DXILResourceMap {
/// ambiguous so multiple creation instructions may be returned. The resulting
/// ResourceInfo can be used to depuplicate unique handles that
/// reference the same resource
- SmallVector<dxil::ResourceInfo> findByUse(const Value *Key) const;
+ SmallVector<dxil::ResourceInfo *> findByUse(const Value *Key);
----------------
V-FEXrt wrote:
Now that setting the value is internal to the analysis, it might make sense to make this an internal/static function? Feels a bit strange to leave the non-const function in the public api.
Thoughts?
https://github.com/llvm/llvm-project/pull/135669
More information about the llvm-commits
mailing list