[llvm] bcbdbd2 - [llvm][ELF][build attributes] Change StringRef to std::string for BuildAttributeSubSection::Name (#135625)

[via llvm-commits]

Author: SivanShani-Arm
Date: 2025-04-14T14:59:24+01:00
New Revision: bcbdbd25c0a2608299a4e97f12076be06a64d724

URL: https://github.com/llvm/llvm-project/commit/bcbdbd25c0a2608299a4e97f12076be06a64d724
DIFF: https://github.com/llvm/llvm-project/commit/bcbdbd25c0a2608299a4e97f12076be06a64d724.diff

LOG: [llvm][ELF][build attributes] Change StringRef to std::string for BuildAttributeSubSection::Name (#135625)

BuildAttributeSubSection::Name must be a std::string instead of
StringRef because it may be assigned from non-persistent memory.
StringRef is non-owning and unsafe in this context. This change ensures
the subsection name owns its memory, preventing use-after-free or
dangling references.

Context: Work in progress in PR #131990.

Added: 
    

Modified: 
    llvm/include/llvm/Support/ELFAttributes.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/Support/ELFAttributes.h b/llvm/include/llvm/Support/ELFAttributes.h
index 6782aec6050ad..d652e2586e9e5 100644
--- a/llvm/include/llvm/Support/ELFAttributes.h
+++ b/llvm/include/llvm/Support/ELFAttributes.h
@@ -36,7 +36,7 @@ struct BuildAttributeItem {
       : Type(Ty), Tag(Tg), IntValue(IV), StringValue(std::move(SV)) {}
 };
 struct BuildAttributeSubSection {
-  StringRef Name;
+  std::string Name;
   unsigned IsOptional;
   unsigned ParameterType;
   SmallVector<BuildAttributeItem, 64> Content;