[llvm] [llvm][ELF][build attributes] Change StringRef to std::string for BuildAttributeSubSection::Name (PR #135625)

[via llvm-commits]

https://github.com/sivan-shani created https://github.com/llvm/llvm-project/pull/135625

BuildAttributeSubSection::Name must be a std::string instead of StringRef because it may be assigned from non-persistent memory. StringRef is non-owning and unsafe in this context. This change ensures the subsection name owns its memory, preventing use-after-free or dangling references.

Context: Work in progress in PR #131990.

>From a901606ec7cfebf779a24f2ebe28e6768b9bc79b Mon Sep 17 00:00:00 2001
From: Sivan Shani <sivan.shani at arm.com>
Date: Mon, 14 Apr 2025 14:47:18 +0100
Subject: [PATCH] [llvm][ELF][build attributes] Change StringRef to std::string
 for BuildAttributeSubSection::Name

BuildAttributeSubSection::Name must be a std::string instead of StringRef because it may be assigned from non-persistent memory. StringRef is non-owning and unsafe in this context.
This change ensures the subsection name owns its memory, preventing use-after-free or dangling references.

Context: Work in progress in PR #131990.
---
 llvm/include/llvm/Support/ELFAttributes.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/llvm/include/llvm/Support/ELFAttributes.h b/llvm/include/llvm/Support/ELFAttributes.h
index 6782aec6050ad..d652e2586e9e5 100644
--- a/llvm/include/llvm/Support/ELFAttributes.h
+++ b/llvm/include/llvm/Support/ELFAttributes.h
@@ -36,7 +36,7 @@ struct BuildAttributeItem {
       : Type(Ty), Tag(Tg), IntValue(IV), StringValue(std::move(SV)) {}
 };
 struct BuildAttributeSubSection {
-  StringRef Name;
+  std::string Name;
   unsigned IsOptional;
   unsigned ParameterType;
   SmallVector<BuildAttributeItem, 64> Content;