[lld] [llvm] [lld][AArch64][Build Attributes] Add support for converting AArch64 Build Attributes to GNU Properties (PR #131990)

[Jack Styles via llvm-commits]

================
@@ -32,14 +32,21 @@ struct BuildAttributeItem {
   unsigned Tag;
   unsigned IntValue;
   std::string StringValue;
+  BuildAttributeItem() {};
   BuildAttributeItem(Types Ty, unsigned Tg, unsigned IV, std::string SV)
       : Type(Ty), Tag(Tg), IntValue(IV), StringValue(std::move(SV)) {}
 };
+
 struct BuildAttributeSubSection {
-  StringRef Name;
+  std::string Name;
----------------
Stylie777 wrote:

What is the motivation for changing this to a `std::string`? `StringRef` is used throughout the LLVM Project and has functions available for returning the value as a different datatype such as a `std::string`. See https://llvm.org/doxygen/classllvm_1_1StringRef.html

https://github.com/llvm/llvm-project/pull/131990