[llvm] ebd1667 - [CodeGen] Avoid repeated hash lookups (NFC) (#135584)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 14 01:03:10 PDT 2025


Author: Kazu Hirata
Date: 2025-04-14T01:03:06-07:00
New Revision: ebd1667059e7b2865a8e419a21df4d4c9735869c

URL: https://github.com/llvm/llvm-project/commit/ebd1667059e7b2865a8e419a21df4d4c9735869c
DIFF: https://github.com/llvm/llvm-project/commit/ebd1667059e7b2865a8e419a21df4d4c9735869c.diff

LOG: [CodeGen] Avoid repeated hash lookups (NFC) (#135584)

Added: 
    

Modified: 
    llvm/lib/CodeGen/MachineBlockPlacement.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/CodeGen/MachineBlockPlacement.cpp b/llvm/lib/CodeGen/MachineBlockPlacement.cpp
index 40edc47f3e6bb..47213ede3a33e 100644
--- a/llvm/lib/CodeGen/MachineBlockPlacement.cpp
+++ b/llvm/lib/CodeGen/MachineBlockPlacement.cpp
@@ -1132,11 +1132,13 @@ MachineBlockPlacement::getBestTrellisSuccessor(
   for (auto *Succ : ViableSuccs) {
     for (MachineBasicBlock *SuccPred : Succ->predecessors()) {
       // Skip any placed predecessors that are not BB
-      if (SuccPred != BB)
-        if ((BlockFilter && !BlockFilter->count(SuccPred)) ||
-            BlockToChain[SuccPred] == &Chain ||
-            BlockToChain[SuccPred] == BlockToChain[Succ])
+      if (SuccPred != BB) {
+        if (BlockFilter && !BlockFilter->count(SuccPred))
           continue;
+        const BlockChain *SuccPredChain = BlockToChain[SuccPred];
+        if (SuccPredChain == &Chain || SuccPredChain == BlockToChain[Succ])
+          continue;
+      }
       BlockFrequency EdgeFreq = MBFI->getBlockFreq(SuccPred) *
                                 MBPI->getEdgeProbability(SuccPred, Succ);
       Edges[SuccIndex].push_back({EdgeFreq, SuccPred, Succ});


        


More information about the llvm-commits mailing list