[llvm] [CostModel] Remove optional from InstructionCost::getValue() (PR #135596)
via llvm-commits
llvm-commits at lists.llvm.org
Mon Apr 14 01:01:45 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions cpp,h -- llvm/include/llvm/CodeGen/BasicTTIImpl.h llvm/include/llvm/Support/InstructionCost.h llvm/include/llvm/Transforms/Utils/UnrollLoop.h llvm/lib/Analysis/CostModel.cpp llvm/lib/CodeGen/SelectOptimize.cpp llvm/lib/Target/AArch64/AArch64ISelLowering.cpp llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp llvm/lib/Target/AMDGPU/AMDGPUTargetTransformInfo.cpp llvm/lib/Target/PowerPC/PPCTargetTransformInfo.cpp llvm/lib/Target/RISCV/RISCVISelLowering.cpp llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp llvm/lib/Target/SystemZ/SystemZTargetTransformInfo.cpp llvm/lib/Target/X86/X86TargetTransformInfo.cpp llvm/lib/Transforms/IPO/FunctionSpecialization.cpp llvm/lib/Transforms/IPO/PartialInlining.cpp llvm/lib/Transforms/Scalar/ConstantHoisting.cpp llvm/lib/Transforms/Scalar/LoopDataPrefetch.cpp llvm/lib/Transforms/Scalar/LoopStrengthReduce.cpp llvm/lib/Transforms/Scalar/LoopUnrollPass.cpp llvm/lib/Transforms/Vectorize/LoopVectorize.cpp llvm/unittests/Support/InstructionCostTest.cpp
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp b/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
index 966652bf2..2d3c8f219 100644
--- a/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
+++ b/llvm/lib/Target/AMDGPU/AMDGPUSplitModule.cpp
@@ -205,8 +205,7 @@ static CostType calculateFunctionCosts(GetTTIFn GetTTI, Module &M,
TTI.getInstructionCost(&I, TargetTransformInfo::TCK_CodeSize);
assert(Cost != InstructionCost::getMax());
// Assume expensive if we can't tell the cost of an instruction.
- CostType CostVal =
- Cost.getValueOr(TargetTransformInfo::TCC_Expensive);
+ CostType CostVal = Cost.getValueOr(TargetTransformInfo::TCC_Expensive);
assert((FnCost + CostVal) >= FnCost && "Overflow!");
FnCost += CostVal;
}
diff --git a/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp b/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
index c6b3222e7..b2691e9c2 100644
--- a/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
+++ b/llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp
@@ -651,12 +651,11 @@ InstructionCost RISCVTTIImpl::getShuffleCost(TTI::ShuffleKind Kind,
if (!Mask.empty() && LT.first.isValid() && LT.first != 1 &&
shouldSplit(Kind) &&
LT.second.getVectorElementType().getSizeInBits() ==
- Tp->getElementType()->getPrimitiveSizeInBits() &&
+ Tp->getElementType()->getPrimitiveSizeInBits() &&
LT.second.getVectorNumElements() <
- cast<FixedVectorType>(Tp)->getNumElements() &&
- divideCeil(Mask.size(),
- cast<FixedVectorType>(Tp)->getNumElements()) ==
- static_cast<unsigned>(LT.first.getValue())) {
+ cast<FixedVectorType>(Tp)->getNumElements() &&
+ divideCeil(Mask.size(), cast<FixedVectorType>(Tp)->getNumElements()) ==
+ static_cast<unsigned>(LT.first.getValue())) {
unsigned NumRegs = LT.first.getValue();
unsigned VF = cast<FixedVectorType>(Tp)->getNumElements();
unsigned SubVF = PowerOf2Ceil(VF / NumRegs);
``````````
</details>
https://github.com/llvm/llvm-project/pull/135596
More information about the llvm-commits
mailing list