[llvm] [Scalar] Avoid repeated hash lookups (NFC) (PR #135585)

[LLVM Continuous Integration via llvm-commits]

llvm-ci wrote:

LLVM Buildbot has detected a new failure on builder `bolt-x86_64-ubuntu-nfc` running on `bolt-worker` while building `llvm` at step 8 "test-build-bolt-check-bolt".

Full details are available at: https://lab.llvm.org/buildbot/#/builders/92/builds/17097

<details>
<summary>Here is the relevant piece of the build log for the reference</summary>

```
Step 8 (test-build-bolt-check-bolt) failure: test (failure)
0.011 [975/10/1] Performing build step for 'bolt_rt'
ninja: no work to do.
0.012 [974/10/2] Building CXX object tools/llvm-config/CMakeFiles/llvm-config.dir/llvm-config.cpp.o
0.016 [973/10/3] Generating VCSVersion.inc
0.020 [971/9/4] Building CXX object lib/Passes/CMakeFiles/LLVMPasses.dir/PassBuilderPipelines.cpp.o
0.024 [970/9/5] No install step for 'bolt_rt'
0.039 [969/9/6] Completed 'bolt_rt'
0.153 [969/8/7] Linking CXX executable bin/llvm-config
0.160 [969/7/8] Linking CXX static library lib/libLLVMPasses.a
0.678 [967/8/9] Building CXX object tools/clang/lib/Support/CMakeFiles/obj.clangSupport.dir/RISCVVIntrinsicUtils.cpp.o
FAILED: tools/clang/lib/Support/CMakeFiles/obj.clangSupport.dir/RISCVVIntrinsicUtils.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/clang/lib/Support -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/lib/Support -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/clang/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/lib/Support/CMakeFiles/obj.clangSupport.dir/RISCVVIntrinsicUtils.cpp.o -MF tools/clang/lib/Support/CMakeFiles/obj.clangSupport.dir/RISCVVIntrinsicUtils.cpp.o.d -o tools/clang/lib/Support/CMakeFiles/obj.clangSupport.dir/RISCVVIntrinsicUtils.cpp.o -c /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/lib/Support/RISCVVIntrinsicUtils.cpp
In file included from /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/lib/Support/RISCVVIntrinsicUtils.cpp:9:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:541:22: error: declaration of ‘clang::RISCV::RequiredExtensions clang::RISCV::RVVIntrinsicRecord::RequiredExtensions’ changes meaning of ‘RequiredExtensions’ [-fpermissive]
  541 |   RequiredExtensions RequiredExtensions;
      |                      ^~~~~~~~~~~~~~~~~~
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:515:8: note: ‘RequiredExtensions’ declared here as ‘struct clang::RISCV::RequiredExtensions’
  515 | struct RequiredExtensions {
      |        ^~~~~~~~~~~~~~~~~~
1.205 [967/7/10] Building CXX object tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o
FAILED: tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o 
ccache /usr/bin/c++ -DCLANG_EXPORTS -DGTEST_HAS_RTTI=0 -DLLVM_BUILD_STATIC -D_DEBUG -D_GLIBCXX_ASSERTIONS -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/clang/utils/TableGen -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/utils/TableGen -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/tools/clang/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/build/include -I/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/llvm/include -fPIC -fno-semantic-interposition -fvisibility-inlines-hidden -Werror=date-time -Wall -Wextra -Wno-unused-parameter -Wwrite-strings -Wcast-qual -Wno-missing-field-initializers -pedantic -Wno-long-long -Wimplicit-fallthrough -Wno-uninitialized -Wno-nonnull -Wno-class-memaccess -Wno-redundant-move -Wno-pessimizing-move -Wno-noexcept-type -Wdelete-non-virtual-dtor -Wsuggest-override -Wno-comment -Wno-misleading-indentation -Wctad-maybe-unsupported -fdiagnostics-color -ffunction-sections -fdata-sections -fno-common -Woverloaded-virtual -fno-strict-aliasing -O3 -DNDEBUG  -fno-exceptions -funwind-tables -fno-rtti -UNDEBUG -std=c++17 -MD -MT tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o -MF tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o.d -o tools/clang/utils/TableGen/CMakeFiles/clang-tblgen.dir/RISCVVEmitter.cpp.o -c /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/utils/TableGen/RISCVVEmitter.cpp
In file included from /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/utils/TableGen/RISCVVEmitter.cpp:17:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:541:22: error: declaration of ‘clang::RISCV::RequiredExtensions clang::RISCV::RVVIntrinsicRecord::RequiredExtensions’ changes meaning of ‘RequiredExtensions’ [-fpermissive]
  541 |   RequiredExtensions RequiredExtensions;
      |                      ^~~~~~~~~~~~~~~~~~
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:515:8: note: ‘RequiredExtensions’ declared here as ‘struct clang::RISCV::RequiredExtensions’
  515 | struct RequiredExtensions {
      |        ^~~~~~~~~~~~~~~~~~
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/utils/TableGen/RISCVVEmitter.cpp:48:22: error: declaration of ‘clang::RISCV::RequiredExtensions {anonymous}::SemaRecord::RequiredExtensions’ changes meaning of ‘RequiredExtensions’ [-fpermissive]
   48 |   RequiredExtensions RequiredExtensions;
      |                      ^~~~~~~~~~~~~~~~~~
In file included from /home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/utils/TableGen/RISCVVEmitter.cpp:17:
/home/worker/bolt-worker2/bolt-x86_64-ubuntu-nfc/llvm-project/clang/include/clang/Support/RISCVVIntrinsicUtils.h:515:8: note: ‘RequiredExtensions’ declared here as ‘struct clang::RISCV::RequiredExtensions’
  515 | struct RequiredExtensions {
      |        ^~~~~~~~~~~~~~~~~~
1.522 [967/6/11] Linking CXX executable bin/llvm-bat-dump
1.559 [967/5/12] Linking CXX executable tools/bolt/unittests/Profile/ProfileTests
3.084 [967/4/13] Linking CXX executable bin/llvm-dwp
3.554 [967/3/14] Linking CXX executable tools/bolt/unittests/Core/CoreTests
4.823 [967/2/15] Linking CXX executable bin/llc
5.455 [967/1/16] Linking CXX executable bin/lld
ninja: build stopped: subcommand failed.

```

</details>

https://github.com/llvm/llvm-project/pull/135585