[llvm] [RISCV] Error out on incorrectly spelt @plt on call symbols (PR #135324)

Sudharsan Veeravalli via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 11 17:43:52 PDT 2025


================
@@ -2123,22 +2123,25 @@ ParseStatus RISCVAsmParser::parseCallSymbol(OperandVector &Operands) {
 
   if (getLexer().getKind() != AsmToken::Identifier)
     return ParseStatus::NoMatch;
+
   std::string Identifier(getTok().getIdentifier());
+  SMLoc E = getTok().getEndLoc();
 
   if (getLexer().peekTok().is(AsmToken::At)) {
     Lex();
     Lex();
     StringRef PLT;
+    SMLoc PLTLoc = getLoc();
     if (getParser().parseIdentifier(PLT) || PLT != "plt")
----------------
svs-quic wrote:

Copying my comment from here https://github.com/llvm/llvm-project/pull/135044#discussion_r2038897967

Given that we parse and drop the @plt in the assembly that is being printed, shouldn't the end location be the end location of the Identifier (eg foo)?



https://github.com/llvm/llvm-project/pull/135324


More information about the llvm-commits mailing list