[llvm] eb68b91 - [NFC][LLVM] Apply std::move to object being pushed back in findSymbolCommon (#135290)

via llvm-commits llvm-commits at lists.llvm.org
Fri Apr 11 15:49:05 PDT 2025


Author: Shafik Yaghmour
Date: 2025-04-11T15:49:01-07:00
New Revision: eb68b914dd7f1926daf9cfab19b85765f2a60700

URL: https://github.com/llvm/llvm-project/commit/eb68b914dd7f1926daf9cfab19b85765f2a60700
DIFF: https://github.com/llvm/llvm-project/commit/eb68b914dd7f1926daf9cfab19b85765f2a60700.diff

LOG: [NFC][LLVM] Apply std::move to object being pushed back in findSymbolCommon (#135290)

Static analysis found that we could move LineInfo into the Result vector
instead of just copying it.

Added: 
    

Modified: 
    llvm/lib/DebugInfo/Symbolize/Symbolize.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
index b96f97a159243..d154f16f272bd 100644
--- a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
+++ b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
@@ -257,7 +257,7 @@ LLVMSymbolizer::findSymbolCommon(const T &ModuleSpecifier, StringRef Symbol,
     if (LineInfo.FileName != DILineInfo::BadString) {
       if (Opts.Demangle)
         LineInfo.FunctionName = DemangleName(LineInfo.FunctionName, Info);
-      Result.push_back(LineInfo);
+      Result.push_back(std::move(LineInfo));
     }
   }
 


        


More information about the llvm-commits mailing list