[llvm] AArch64: Allow ZEXT+COPY -> FMOV peephole for ZPR registers as well (PR #135436)
Matthias Braun via llvm-commits
llvm-commits at lists.llvm.org
Fri Apr 11 13:33:28 PDT 2025
https://github.com/MatzeB created https://github.com/llvm/llvm-project/pull/135436
None
>From fefa29876a770286179ed6ae384e640f193d852f Mon Sep 17 00:00:00 2001
From: Matthias Braun <matze at braunis.de>
Date: Fri, 11 Apr 2025 13:31:35 -0700
Subject: [PATCH] AArch64: Allow ZEXT+COPY -> FMOV peephole for ZPR registers
as well
---
.../Target/AArch64/AArch64MIPeepholeOpt.cpp | 7 ++-
llvm/test/CodeGen/AArch64/peephole-orr.mir | 45 ++++++++++++++++++-
2 files changed, 49 insertions(+), 3 deletions(-)
diff --git a/llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp b/llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp
index 36a7becbc76d3..71efeaf0d1b88 100644
--- a/llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp
+++ b/llvm/lib/Target/AArch64/AArch64MIPeepholeOpt.cpp
@@ -263,15 +263,18 @@ bool AArch64MIPeepholeOpt::visitORR(MachineInstr &MI) {
// A COPY from an FPR will become a FMOVSWr, so do so now so that we know
// that the upper bits are zero.
if (RC != &AArch64::FPR32RegClass &&
- ((RC != &AArch64::FPR64RegClass && RC != &AArch64::FPR128RegClass) ||
+ ((RC != &AArch64::FPR64RegClass && RC != &AArch64::FPR128RegClass &&
+ RC != &AArch64::ZPRRegClass) ||
SrcMI->getOperand(1).getSubReg() != AArch64::ssub))
return false;
- Register CpySrc = SrcMI->getOperand(1).getReg();
+ Register CpySrc;
if (SrcMI->getOperand(1).getSubReg() == AArch64::ssub) {
CpySrc = MRI->createVirtualRegister(&AArch64::FPR32RegClass);
BuildMI(*SrcMI->getParent(), SrcMI, SrcMI->getDebugLoc(),
TII->get(TargetOpcode::COPY), CpySrc)
.add(SrcMI->getOperand(1));
+ } else {
+ CpySrc = SrcMI->getOperand(1).getReg();
}
BuildMI(*SrcMI->getParent(), SrcMI, SrcMI->getDebugLoc(),
TII->get(AArch64::FMOVSWr), SrcMI->getOperand(0).getReg())
diff --git a/llvm/test/CodeGen/AArch64/peephole-orr.mir b/llvm/test/CodeGen/AArch64/peephole-orr.mir
index 3431676438bd2..f718328ecf2d6 100644
--- a/llvm/test/CodeGen/AArch64/peephole-orr.mir
+++ b/llvm/test/CodeGen/AArch64/peephole-orr.mir
@@ -1,6 +1,49 @@
# NOTE: Assertions have been autogenerated by utils/update_mir_test_checks.py
# RUN: llc -run-pass=aarch64-mi-peephole-opt -o - -mtriple=aarch64-unknown-linux -verify-machineinstrs %s | FileCheck %s
-
+---
+name: copy_fpr128_gpr32
+body: |
+ bb.0:
+ liveins: $q0
+ ; CHECK-LABEL: name: copy_fpr128_gpr32
+ ; CHECK: liveins: $q0
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: [[COPY:%[0-9]+]]:fpr128 = COPY $q0
+ ; CHECK-NEXT: [[COPY1:%[0-9]+]]:fpr32 = COPY [[COPY]].ssub
+ ; CHECK-NEXT: [[FMOVSWr:%[0-9]+]]:gpr32 = FMOVSWr [[COPY1]]
+ %0:fpr128 = COPY $q0
+ %1:gpr32 = COPY %0.ssub:fpr128
+ %2:gpr32 = ORRWrs $wzr, killed %1:gpr32, 0
+...
+---
+name: copy_fpr32_gpr32
+body: |
+ bb.0:
+ liveins: $s0
+ ; CHECK-LABEL: name: copy_fpr32_gpr32
+ ; CHECK: liveins: $s0
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: [[COPY:%[0-9]+]]:fpr32 = COPY $s0
+ ; CHECK-NEXT: [[FMOVSWr:%[0-9]+]]:gpr32 = FMOVSWr [[COPY]]
+ %0:fpr32 = COPY $s0
+ %1:gpr32 = COPY %0:fpr32
+ %2:gpr32 = ORRWrs $wzr, killed %1:gpr32, 0
+...
+---
+name: copy_zpr_gpr32
+body: |
+ bb.0:
+ liveins: $z0
+ ; CHECK-LABEL: name: copy_zpr_gpr32
+ ; CHECK: liveins: $z0
+ ; CHECK-NEXT: {{ $}}
+ ; CHECK-NEXT: [[COPY:%[0-9]+]]:zpr = COPY $z0
+ ; CHECK-NEXT: [[COPY1:%[0-9]+]]:fpr32 = COPY [[COPY]].ssub
+ ; CHECK-NEXT: [[FMOVSWr:%[0-9]+]]:gpr32 = FMOVSWr [[COPY1]]
+ %0:zpr = COPY $z0
+ %1:gpr32 = COPY %0.ssub:zpr
+ %2:gpr32 = ORRWrs $wzr, killed %1:gpr32, 0
+...
---
name: copy_multiple_uses
tracksRegLiveness: true
More information about the llvm-commits
mailing list