[lld] [lld][ELF] improve AMD error message (PR #135082)

Maksim Levental via llvm-commits llvm-commits at lists.llvm.org
Thu Apr 10 21:12:00 PDT 2025


================
@@ -1,4 +1,4 @@
-config.suffixes = [".test", ".s", ".ll", ".bat"]
+config.suffixes = [".test", ".s", ".ll", ".bat", ".yaml"]
----------------
makslevental wrote:

You've gotta be the rudest reviewer I've ever met over in two years and 95 landed PRs of working on LLVM. 

On the previous PR followed me back to my downstream project and criticized me for an honest mistake.  

Then you ask for a test for a patently correct 10 char/1 line PR - which I supplied even though it's absurd.

Now you're criticizing me for not following conventions which you clearly yourself don't have a complete grasp of - **newflash** there are literally `.yaml` [files in this same test set](https://github.com/llvm/llvm-project/blob/04c38981a9ce3e6225669c0e41cab947e3e7989f/lld/test/MachO/zippered.yaml#L4).

Please spend more time learning how to communicate with your colleagues (or I guess just have fun maintaining completely by yourself - your choice :shrug:).

https://github.com/llvm/llvm-project/pull/135082


More information about the llvm-commits mailing list