[llvm] [NFC][LLVM] Apply std::move to object being pushed back in findSymbolCommon (PR #135290)
via llvm-commits
llvm-commits at lists.llvm.org
Thu Apr 10 18:03:03 PDT 2025
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-llvm-binary-utilities
Author: Shafik Yaghmour (shafik)
<details>
<summary>Changes</summary>
Static analysis found that we could move LineInfo into the Result vector instead of just copying it.
---
Full diff: https://github.com/llvm/llvm-project/pull/135290.diff
1 Files Affected:
- (modified) llvm/lib/DebugInfo/Symbolize/Symbolize.cpp (+1-1)
``````````diff
diff --git a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
index b96f97a159243..d154f16f272bd 100644
--- a/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
+++ b/llvm/lib/DebugInfo/Symbolize/Symbolize.cpp
@@ -257,7 +257,7 @@ LLVMSymbolizer::findSymbolCommon(const T &ModuleSpecifier, StringRef Symbol,
if (LineInfo.FileName != DILineInfo::BadString) {
if (Opts.Demangle)
LineInfo.FunctionName = DemangleName(LineInfo.FunctionName, Info);
- Result.push_back(LineInfo);
+ Result.push_back(std::move(LineInfo));
}
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/135290
More information about the llvm-commits
mailing list