[lld] [lld][ELF] improve AMD error message (PR #135082)

Fangrui Song via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 9 22:00:45 PDT 2025


================
@@ -143,7 +143,7 @@ uint32_t AMDGPU::calcEFlags() const {
   case ELFABIVERSION_AMDGPU_HSA_V6:
     return calcEFlagsV6();
   default:
-    Err(ctx) << "unknown abi version: " << abiVersion;
+    Err(ctx) << "unknown amd-hsa abi version: " << static_cast<int>(abiVersion);
----------------
MaskRay wrote:

Needs a test. Perhaps Update  amdgpu-abi-version-err.s

I don't think the cast is necessary?

Usually "ABI" instead of abi. Why is amd-hsa in lower case?

https://github.com/llvm/llvm-project/pull/135082


More information about the llvm-commits mailing list