[compiler-rt] Revert "Replace bool operator== for VersionType in sanitizer_mac.h" (PR #135127)

[via llvm-commits]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-compiler-rt-sanitizer

Author: Jonas Devlieghere (JDevlieghere)

<details>
<summary>Changes</summary>

Reverts llvm/llvm-project#<!-- -->135068 because it breaks building compiler-rt on Darwin. 

https://green.lab.llvm.org/job/clang-stage1-RA/
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/as-lldb-cmake/
https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/

---
Full diff: https://github.com/llvm/llvm-project/pull/135127.diff


1 Files Affected:

- (modified) compiler-rt/lib/sanitizer_common/sanitizer_mac.h (+3-5) 


``````````diff
diff --git a/compiler-rt/lib/sanitizer_common/sanitizer_mac.h b/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
index 4de0605e18f03..f0a97d098eea0 100644
--- a/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
+++ b/compiler-rt/lib/sanitizer_common/sanitizer_mac.h
@@ -37,6 +37,9 @@ struct VersionBase {
 
   VersionBase(u16 major, u16 minor) : major(major), minor(minor) {}
 
+  bool operator==(const VersionType &other) const {
+    return major == other.major && minor == other.minor;
+  }
   bool operator>=(const VersionType &other) const {
     return major > other.major ||
            (major == other.major && minor >= other.minor);
@@ -44,11 +47,6 @@ struct VersionBase {
   bool operator<(const VersionType &other) const { return !(*this >= other); }
 };
 
-template <typename VersionType>
-bool operator==(const VersionType &self, const VersionType &other) {
-  return self.major == other.major && self.minor == other.minor;
-}
-
 struct MacosVersion : VersionBase<MacosVersion> {
   MacosVersion(u16 major, u16 minor) : VersionBase(major, minor) {}
 };

``````````

</details>


https://github.com/llvm/llvm-project/pull/135127