[llvm] [bazel][mlir] Add missing dep for X86Vector (PR #135069)

Jakub Kuderski via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 9 12:12:53 PDT 2025


https://github.com/kuhar updated https://github.com/llvm/llvm-project/pull/135069

>From 4396459b99a6043639f885655b0c585f95f356c8 Mon Sep 17 00:00:00 2001
From: Jakub Kuderski <jakub at nod-labs.com>
Date: Wed, 9 Apr 2025 15:02:42 -0400
Subject: [PATCH 1/3] [bazel][mlir] Add missing dep for X86Vector

Follow up after https://github.com/llvm/llvm-project/pull/133692
---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index e69fc0e50a5b3..75b5b796addcc 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -2237,7 +2237,10 @@ gentbl_cc_library(
 
 td_library(
     name = "X86VectorTdFiles",
-    srcs = ["include/mlir/Dialect/X86Vector/X86Vector.td"],
+    srcs = [
+        "include/mlir/Dialect/X86Vector/X86Vector.td",
+        "include/mlir/Dialect/X86Vector/X86VectorInterfaces.td",
+    ],
     includes = ["include"],
     deps = [
         ":InferTypeOpInterfaceTdFiles",

>From 10f96379561a6ac92a9421c09142b8428e826104 Mon Sep 17 00:00:00 2001
From: Jakub Kuderski <jakub at nod-labs.com>
Date: Wed, 9 Apr 2025 15:11:24 -0400
Subject: [PATCH 2/3] Add missing interface gen

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 75b5b796addcc..0a85e61c4c553 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -2269,6 +2269,17 @@ gentbl_cc_library(
     deps = [":X86VectorTdFiles"],
 )
 
+gentbl_cc_library(
+    name = "X86VectorInterfacesIncGen",
+    tbl_outs = {
+        "include/mlir/Dialect/X86Vector/X86VectorInterfaces.h.inc": ["-gen-op-interface-decls"],
+        "include/mlir/Dialect/X86Vector/X86VectorInterfaces.h.inc": ["-gen-op-interface-defs"],
+    },
+    tblgen = ":mlir-tblgen",
+    td_file = "include/mlir/Dialect/X86Vector/X86VectorInterfaces.td",
+    deps = [":X86VectorTdFiles"],
+)
+
 cc_library(
     name = "X86VectorDialect",
     srcs = ["lib/Dialect/X86Vector/IR/X86VectorDialect.cpp"],
@@ -2281,6 +2292,7 @@ cc_library(
         ":LLVMDialect",
         ":SideEffectInterfaces",
         ":X86VectorIncGen",
+        ":X86VectorInterfacesIncGen",
     ],
 )
 

>From 2ba4b7e6e65e37b23bf15eda5b8e75c6a35ac536 Mon Sep 17 00:00:00 2001
From: Jakub Kuderski <jakub at nod-labs.com>
Date: Wed, 9 Apr 2025 15:12:43 -0400
Subject: [PATCH 3/3] Fix typo

---
 utils/bazel/llvm-project-overlay/mlir/BUILD.bazel | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
index 0a85e61c4c553..ea31c9ecea4b1 100644
--- a/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
+++ b/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel
@@ -2273,7 +2273,7 @@ gentbl_cc_library(
     name = "X86VectorInterfacesIncGen",
     tbl_outs = {
         "include/mlir/Dialect/X86Vector/X86VectorInterfaces.h.inc": ["-gen-op-interface-decls"],
-        "include/mlir/Dialect/X86Vector/X86VectorInterfaces.h.inc": ["-gen-op-interface-defs"],
+        "include/mlir/Dialect/X86Vector/X86VectorInterfaces.cpp.inc": ["-gen-op-interface-defs"],
     },
     tblgen = ":mlir-tblgen",
     td_file = "include/mlir/Dialect/X86Vector/X86VectorInterfaces.td",



More information about the llvm-commits mailing list