[llvm] 1e9f46c - llvm-reduce: Fix taking wrong error before exit (#135020)

via llvm-commits llvm-commits at lists.llvm.org
Wed Apr 9 09:11:12 PDT 2025


Author: Matt Arsenault
Date: 2025-04-09T18:11:08+02:00
New Revision: 1e9f46c1b34cce7df4f2b4c392ccb0a540d7a6a6

URL: https://github.com/llvm/llvm-project/commit/1e9f46c1b34cce7df4f2b4c392ccb0a540d7a6a6
DIFF: https://github.com/llvm/llvm-project/commit/1e9f46c1b34cce7df4f2b4c392ccb0a540d7a6a6.diff

LOG: llvm-reduce: Fix taking wrong error before exit (#135020)

Added: 
    

Modified: 
    llvm/tools/llvm-reduce/ReducerWorkItem.cpp

Removed: 
    


################################################################################
diff  --git a/llvm/tools/llvm-reduce/ReducerWorkItem.cpp b/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
index ad40d8d8baa36..8d2675c685038 100644
--- a/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
+++ b/llvm/tools/llvm-reduce/ReducerWorkItem.cpp
@@ -757,13 +757,20 @@ void ReducerWorkItem::readBitcode(MemoryBufferRef Data, LLVMContext &Ctx,
     WithColor::error(errs(), ToolName) << IF.takeError();
     exit(1);
   }
+
   BitcodeModule BM = IF->Mods[0];
   Expected<BitcodeLTOInfo> LI = BM.getLTOInfo();
+  if (!LI) {
+    WithColor::error(errs(), ToolName) << LI.takeError();
+    exit(1);
+  }
+
   Expected<std::unique_ptr<Module>> MOrErr = BM.parseModule(Ctx);
-  if (!LI || !MOrErr) {
-    WithColor::error(errs(), ToolName) << IF.takeError();
+  if (!MOrErr) {
+    WithColor::error(errs(), ToolName) << MOrErr.takeError();
     exit(1);
   }
+
   LTOInfo = std::make_unique<BitcodeLTOInfo>(*LI);
   M = std::move(MOrErr.get());
 }


        


More information about the llvm-commits mailing list