[compiler-rt] Fix some page size assumptions in the HWASan tests. (PR #134941)
via llvm-commits
llvm-commits at lists.llvm.org
Tue Apr 8 15:54:59 PDT 2025
github-actions[bot] wrote:
<!--LLVM CODE FORMAT COMMENT: {clang-format}-->
:warning: C/C++ code formatter, clang-format found issues in your code. :warning:
<details>
<summary>
You can test this locally with the following command:
</summary>
``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions c -- compiler-rt/test/hwasan/TestCases/Linux/release-shadow.c compiler-rt/test/hwasan/TestCases/heap-buffer-overflow.c compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c
``````````
</details>
<details>
<summary>
View the diff from clang-format here.
</summary>
``````````diff
diff --git a/compiler-rt/test/hwasan/TestCases/Linux/release-shadow.c b/compiler-rt/test/hwasan/TestCases/Linux/release-shadow.c
index 988de511a..c17dc8453 100644
--- a/compiler-rt/test/hwasan/TestCases/Linux/release-shadow.c
+++ b/compiler-rt/test/hwasan/TestCases/Linux/release-shadow.c
@@ -22,7 +22,8 @@ const size_t kNumPages = 16 * kNumShadowPages;
size_t page_size, map_size;
void sync_rss() {
- char *page = (char *)mmap(0, page_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
+ char *page = (char *)mmap(0, page_size, PROT_READ | PROT_WRITE,
+ MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
// Linux kernel updates RSS counters after a set number of page faults.
for (int i = 0; i < 100; ++i) {
page[0] = 42;
@@ -66,7 +67,8 @@ int main() {
fprintf(stderr, "starting rss %zu\n", current_rss());
fprintf(stderr, "shadow pages: %zu\n", kNumShadowPages);
- void *p = mmap(0, map_size, PROT_READ | PROT_WRITE, MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
+ void *p = mmap(0, map_size, PROT_READ | PROT_WRITE,
+ MAP_PRIVATE | MAP_ANONYMOUS, 0, 0);
fprintf(stderr, "p = %p\n", p);
size_t total_count = 10;
diff --git a/compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c b/compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c
index a9fd7d66d..ff3e3fc85 100644
--- a/compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c
+++ b/compiler-rt/test/hwasan/TestCases/tag-mismatch-border-address.c
@@ -16,8 +16,8 @@ extern void *__hwasan_shadow_memory_dynamic_address;
int main(int argc, char **argv) {
size_t page_size = getauxval(AT_PAGESZ);
void *high_addr = (char *)__hwasan_shadow_memory_dynamic_address - page_size;
- void *r = mmap(high_addr, page_size, PROT_READ, MAP_FIXED | MAP_ANON | MAP_PRIVATE,
- -1, 0);
+ void *r = mmap(high_addr, page_size, PROT_READ,
+ MAP_FIXED | MAP_ANON | MAP_PRIVATE, -1, 0);
if (r == MAP_FAILED) {
fprintf(stderr, "Failed to mmap\n");
abort();
``````````
</details>
https://github.com/llvm/llvm-project/pull/134941
More information about the llvm-commits
mailing list