[llvm] [dsymutil] Avoid copying binary swiftmodules built from textual (PR #134719)

via llvm-commits llvm-commits at lists.llvm.org
Mon Apr 7 12:59:41 PDT 2025


github-actions[bot] wrote:

<!--LLVM CODE FORMAT COMMENT: {clang-format}-->


:warning: C/C++ code formatter, clang-format found issues in your code. :warning:

<details>
<summary>
You can test this locally with the following command:
</summary>

``````````bash
git-clang-format --diff HEAD~1 HEAD --extensions h,cpp -- llvm/tools/dsymutil/SwiftModule.cpp llvm/tools/dsymutil/SwiftModule.h llvm/tools/dsymutil/DebugMap.cpp llvm/tools/dsymutil/DwarfLinkerForBinary.cpp llvm/tools/dsymutil/RelocationMap.h
``````````

</details>

<details>
<summary>
View the diff from clang-format here.
</summary>

``````````diff
diff --git a/llvm/tools/dsymutil/DebugMap.cpp b/llvm/tools/dsymutil/DebugMap.cpp
index 1ce7e9b9e..f1cd7e402 100644
--- a/llvm/tools/dsymutil/DebugMap.cpp
+++ b/llvm/tools/dsymutil/DebugMap.cpp
@@ -50,8 +50,8 @@ bool DebugMapObject::addSymbol(StringRef Name,
     return true;
   }
 
-  auto InsertResult = Symbols.insert(std::make_pair(
-      Name, SymbolMapping(ObjectAddress, LinkedAddress, Size)));
+  auto InsertResult = Symbols.insert(
+      std::make_pair(Name, SymbolMapping(ObjectAddress, LinkedAddress, Size)));
 
   if (ObjectAddress && InsertResult.second)
     AddressToMapping[*ObjectAddress] = &*InsertResult.first;
diff --git a/llvm/tools/dsymutil/SwiftModule.cpp b/llvm/tools/dsymutil/SwiftModule.cpp
index ba7ee8f1c..a6e3042f4 100644
--- a/llvm/tools/dsymutil/SwiftModule.cpp
+++ b/llvm/tools/dsymutil/SwiftModule.cpp
@@ -175,7 +175,8 @@ llvm::Expected<bool> IsBuiltFromSwiftInterface(llvm::StringRef data) {
   if (llvm::Error Err = checkModuleSignature(cursor, SWIFTMODULE_SIGNATURE))
     return llvm::joinErrors(
         llvm::createStringError("could not check signature"), std::move(Err));
-  if (llvm::Error Err = enterTopLevelModuleBlock(cursor, MODULE_BLOCK_ID, false))
+  if (llvm::Error Err =
+          enterTopLevelModuleBlock(cursor, MODULE_BLOCK_ID, false))
     return llvm::joinErrors(
         llvm::createStringError("could not enter top level block"),
         std::move(Err));

``````````

</details>


https://github.com/llvm/llvm-project/pull/134719


More information about the llvm-commits mailing list