https://github.com/nikic commented: Looks basically fine to me. I'd recommend rebasing this. The surrounding code has changed significantly, even if Git thinks it merges cleanly. https://github.com/llvm/llvm-project/pull/129537